fix(vscode): Fixing Syntax Issue Causing Local Build Error

[lambrianmsft]

Commit Type

• feature - New functionality
• fix - Bug fix
• refactor - Code restructuring without behavior change
• perf - Performance improvement
• docs - Documentation update
• test - Test-related changes
• chore - Maintenance/tooling

Risk Level

• Low - Minor changes, limited scope
• Medium - Moderate changes, some user impact
• High - Major changes, significant user/system impact

What & Why

This fixes an issue with building the vscode extension locally. The syntax is currently not allowed as is.

Impact of Change

• Users:
  N/A
• Developers:
  N/A
• System:
  System can build as expected now

Test Plan

• Unit tests added/updated
• E2E tests added/updated
• Manual testing completed
• Tested in:

Contributors

Screenshots/Videos

[github-actions]

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

• Current: fix(vscode): Fixing Syntax Issue Causing Local Build Error
• Issue: The title is descriptive and accurate, but uses "Fixing" (continuous tense). Conventional commit style prefers the imperative form ("fix") and it's helpful to mention the specific file when the change is small and targeted.
• Recommendation: Use imperative tense and include the affected file for clarity. Example: fix(vscode): fix syntax in foundryAgentService.ts causing local build error

---

✅ Commit Type

• Properly selected (fix).
• Only one option is selected which is correct.

---

✅ Risk Level

• The PR body marks the change as Low and the repo has the label risk:low attached. The code diff is a single-line safety/syntax change (1 deletion, 1 addition) so the risk assessment of Low is appropriate.

---

✅ What & Why

• Current: "This fixes an issue with building the vscode extension locally. The syntax is currently not allowed as is."
• Issue: The description is concise and acceptable, but could be slightly expanded to state the root cause (invalid optional chaining / bracket syntax) and the specific file modified.
• Recommendation: Expand to one or two sentences clarifying the exact syntax error and file. Example: Fix invalid optional chaining usage in libs/logic-apps-shared/src/designer-client-services/lib/standard/foundryAgentService.ts which prevented the vscode extension from building locally.

---

⚠️ Impact of Change

• The Impact section currently lists N/A for Users and Developers and a short System note. For clarity for reviewers and future readers, please explicitly mention who is impacted.
• Recommendation:
  • Users: No user-facing changes (none).
  • Developers: Developers who build the VSCode extension locally or run related TypeScript checks/CI will be able to build successfully. Mention repository area or commands that were failing.
  • System: CI/build agents should no longer fail on this syntax error; note whether CI was re-run or will be run.

---

✅ Test Plan

• Manual testing completed was selected in the PR and is reasonable for a small syntax fix. However, please add brief, reproducible manual test steps and confirm CI status if applicable.
• Recommendation: Add steps like: 1) yarn install; 2) cd extensions/vscode && yarn build or the specific command you ran that previously failed and now succeeds. If CI ran successfully, note that too.

---

⚠️ Contributors

• Currently blank. This is optional, but we recommend adding any reviewers, PMs, or designers who contributed to the fix or discussion. If none, leaving it blank is fine.

---

✅ Screenshots/Videos

• Not applicable for this change.

---

Summary Table

Section	Status	Recommendation
Title	✅	Use imperative tense and optionally include filename.
Commit Type	✅	No change needed.
Risk Level	✅	No change needed (low).
What & Why	✅	Expand slightly to name file and root cause.
Impact of Change	⚠️	Specify developer/build impact instead of N/A.
Test Plan	✅	Add short manual steps and CI result if available.
Contributors	⚠️	Optional: credit contributors if applicable.
Screenshots/Videos	✅	Not applicable.

---

Final notes: This PR passes the PR title/body checklist. The advised risk level is "low" and matches the PR's label. Please consider the small suggested edits: adjust the PR title to imperative tense and mention the file, expand "What & Why" with the root cause and file path, fill out the Impact section to indicate who (developers/builds) is affected, and add brief manual test steps and CI confirmation. After applying those minor improvements, this PR is ready to merge. Thank you!

---

Last updated: Fri, 27 Mar 2026 22:52:18 GMT

[Copilot]

Pull request overview

Fixes a TypeScript syntax incompatibility in the VS Code extension build path by replacing optional-chaining element access with a more broadly supported runtime check when extracting Foundry agent version data.

Changes:

• Updated extractVersionsData to avoid result?.['data'] syntax.
• Preserved existing behavior by still safely returning [] when the response shape doesn’t match expected formats.