New commendlet to get nfs connect value#390
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new AVS Run Command function to the Microsoft.AVS.NFS module for retrieving NFS nConnect (TCP connections) configuration per host for a given datastore/cluster, along with module export wiring and Pester coverage.
Changes:
- Added
Get-NFSDatastoreNConnectValueto query NFS nConnect/connection details across connected hosts in a cluster. - Exported the new function via
Microsoft.AVS.NFS.psd1. - Added initial Pester tests for module loading and several validation/error paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
Microsoft.AVS.NFS/Microsoft.AVS.NFS.psm1 |
Adds the new Get-NFSDatastoreNConnectValue implementation and sets NamedOutputs. |
Microsoft.AVS.NFS/Microsoft.AVS.NFS.psd1 |
Exports the new function in FunctionsToExport. |
tests/Microsoft.AVS.NFS.Tests.ps1 |
Introduces Pester tests covering import/export + parameter and failure-mode validation for the new cmdlet. |
et1975
approved these changes
May 11, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
decf95e to
1042583
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #
The changes in this PR are as follows:
I have read the contributor guidelines and have completed the following:
AVSAttributeto newly exported functions.