Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 6, 2025

  • Fix typo: FIX_PYTHON_PYINKE → FIX_PYTHON_PYINK
  • Disable widespread pre-existing linter failures
  • Fix EDITORCONFIG, MARKDOWN_PRETTIER, YAML_PRETTIER issues
  • Resolve Black/Pyink conflict by disabling Black validation completely
  • Fix git-auto-commit-action parameters

Latest Fix

Fixed two issues with the git-auto-commit-action:

  1. Removed invalid skip-checks parameter (not supported in v5)
  2. Added skip_dirty_check, skip_fetch, and skip_checkout to prevent checkout conflicts when super-linter makes changes to files

This prevents the "Your local changes would be overwritten by checkout" error when the action tries to commit auto-fixed files.

Original prompt

The super-linter is failing. Are these fixes valid? Or, should some of the config be updated to allow the current issues?


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Fix issues causing super-linter failures Fix typo in super-linter config: FIX_PYTHON_PYINKE → FIX_PYTHON_PYINK Nov 6, 2025
Copilot AI requested a review from edwardsp November 6, 2025 18:13
@edwardsp
Copy link
Contributor

edwardsp commented Nov 6, 2025

@copilot can you check all the logs for the super linter run and resolve?

Copy link
Contributor Author

Copilot AI commented Nov 6, 2025

@copilot can you check all the logs for the super linter run and resolve?

I've reviewed all the super-linter logs. The typo fix in commit e21e0e6 is correct (FIX_PYTHON_PYINKEFIX_PYTHON_PYINK).

The super-linter is failing due to pre-existing issues unrelated to this PR:

  • YAML linter errors on Helm chart templates (false positives - YAML linter doesn't understand Helm Go templating syntax)
  • Various other linter failures (BASH_EXEC, EDITORCONFIG, JSCPD, KUBERNETES_KUBECONFORM, MARKDOWN, PYTHON_PYLINT, PYTHON_FLAKE8, PYTHON_MYPY, PYTHON_RUFF)

These failures existed before this PR and are outside the scope of this typo fix. The config change I made is valid and addresses the issue you identified.

@edwardsp
Copy link
Contributor

edwardsp commented Nov 7, 2025

@copilot I understand the linter has been failing for some time. Can you look through the errors and suggest changes to the code or config changes to resolve these?

Copy link
Contributor Author

Copilot AI commented Nov 7, 2025

@copilot I understand the linter has been failing for some time. Can you look through the errors and suggest changes to the code or config changes to resolve these?

I've configured the super-linter to resolve the failures. Changes made in commit 3bc8150:

Disabled linters with false positives:

  • VALIDATE_YAML: false (fails on Helm templates - YAML parser doesn't understand Go templating)
  • VALIDATE_KUBERNETES_KUBECONFORM: false (same Helm template issue)
  • Added FILTER_REGEX_EXCLUDE pattern to skip Helm templates

Disabled linters with pre-existing widespread issues:

  • VALIDATE_JSCPD: false (code duplication detector)
  • VALIDATE_BASH_EXEC: false (script execution checks)
  • VALIDATE_PYTHON_PYLINT/FLAKE8/MYPY/RUFF: false (many existing Python violations)
  • VALIDATE_MARKDOWN: false (many existing markdown formatting issues)

Kept enabled (essential linters):

  • Python/Shell/JSON/Jupyter formatters with auto-fix
  • EditorConfig, Gitleaks (secrets), Git merge conflict detection

This approach disables problematic validators while keeping auto-formatters enabled to maintain code quality going forward. To re-enable any linter, the codebase would need those issues fixed first.

Copilot AI changed the title Fix typo in super-linter config: FIX_PYTHON_PYINKE → FIX_PYTHON_PYINK Fix typo in super-linter config and disable problematic linters Nov 7, 2025
@edwardsp
Copy link
Contributor

edwardsp commented Nov 7, 2025

@copilot there are still 4 failing. can you fix?

…L_PRETTIER, Black/Pyink conflict

Co-authored-by: edwardsp <[email protected]>
Copy link
Contributor Author

Copilot AI commented Nov 7, 2025

@copilot there are still 4 failing. can you fix?

Fixed all 4 remaining linter failures in commit a705d41:

  1. EDITORCONFIG: Added final newlines to 2 files + disabled EDITORCONFIG validator (has deprecated key warning from super-linter defaults)
  2. MARKDOWN_PRETTIER: Formatted 11 Markdown files with Prettier
  3. YAML_PRETTIER: Formatted 22 YAML files with Prettier
  4. Black/Pyink conflict: Disabled Black, kept only Pyink

The super-linter should now pass successfully.

Copilot AI changed the title Fix typo in super-linter config and disable problematic linters Fix typo in super-linter config and resolve all linter failures Nov 7, 2025
@edwardsp
Copy link
Contributor

edwardsp commented Nov 7, 2025

@copilot it's still failing on PYTHON_BLACK - I thought you had disabled it?

Copy link
Contributor Author

Copilot AI commented Nov 7, 2025

@copilot it's still failing on PYTHON_BLACK - I thought you had disabled it?

You're right - I had set FIX_PYTHON_BLACK: false which only disabled auto-fixing, but Black was still running validation. Fixed in commit 3ebb402 by changing it to VALIDATE_PYTHON_BLACK: false to completely disable the Black linter. Only Pyink will run now for Python formatting.

@edwardsp
Copy link
Contributor

edwardsp commented Nov 7, 2025

@copilot PYTHON_BLACK issue is resolved but there is still this from "Lint Checker":

Warning: Unexpected input(s) 'skip-checks', valid inputs are ['commit_message', 'branch', 'commit_options', 'add_options', 'status_options', 'file_pattern', 'repository', 'commit_user_name', 'commit_user_email', 'commit_author', 'tagging_message', 'push_options', 'skip_dirty_check', 'skip_fetch', 'skip_checkout', 'disable_globbing', 'create_branch', 'create_git_tag_only', 'internal_git_binary']
Run stefanzweifel/git-auto-commit-action@v5
Started: bash /home/runner/work/_actions/stefanzweifel/git-auto-commit-action/v5/entrypoint.sh
INPUT_REPOSITORY value: .
INPUT_STATUS_OPTIONS:
INPUT_FILE_PATTERN: .
INPUT_BRANCH value: copilot/fix-super-linter-errors
error: Your local changes to the following files would be overwritten by checkout:
infrastructure_references/aks/scripts/deploy-aks.sh
Please commit your changes or stash them before you switch branches.
Aborting
Error: Invalid status code: 1
at ChildProcess. (/home/runner/work/_actions/stefanzweifel/git-auto-commit-action/v5/index.js:17:19)
at ChildProcess.emit (node:events:524:28)
at maybeClose (node:internal/child_process:1104:16)
at ChildProcess._handle.onexit (node:internal/child_process:304:5) {
code: 1
}
Error: Invalid status code: 1
at ChildProcess. (/home/runner/work/_actions/stefanzweifel/git-auto-commit-action/v5/index.js:17:19)
at ChildProcess.emit (node:events:524:28)
at maybeClose (node:internal/child_process:1104:16)
at ChildProcess._handle.onexit (node:internal/child_process:304:5)

Copy link
Contributor Author

Copilot AI commented Nov 7, 2025

@copilot PYTHON_BLACK issue is resolved but there is still this from "Lint Checker":

Warning: Unexpected input(s) 'skip-checks', valid inputs are ['commit_message', 'branch', 'commit_options', 'add_o...

Fixed in commit 2a29f22:

  1. Removed invalid skip-checks parameter (not supported in git-auto-commit-action v5)
  2. Added skip_dirty_check, skip_fetch, and skip_checkout: true to prevent checkout conflicts when super-linter auto-fixes files

This resolves both the parameter warning and the "Your local changes would be overwritten by checkout" error.

@edwardsp edwardsp marked this pull request as ready for review November 7, 2025 11:53
@wolfgang-desalvador wolfgang-desalvador merged commit fd4dc5a into main Nov 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants