-
Notifications
You must be signed in to change notification settings - Fork 8
Add Azure Container Storage support and unified FIO testing tool #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: edwardsp <[email protected]>
|
@copilot We don't need a type for the container storage (as an env var or when creating aks with az command). The docs should only mention ephemeral - clear up readme. Set default to "true". Make the example a helm chart and reference that from teh main readme |
Co-authored-by: edwardsp <[email protected]>
|
@copilot you do not need |
…flag Co-authored-by: edwardsp <[email protected]>
Done in commit f92b683. Removed |
|
@copilot I don't like the example. Can you update infrastructure_validations/aks/blobfuse/helm/fio to either provide options for the different storage:
Rename to infrastructure_validations/aks/fio/helm/fio. Put the blobfuse example configuations into the docs for the blobfuse shared storage (just embed them rather than providing separate files) Remove the current azure container storage example. |
…ndalone examples Co-authored-by: edwardsp <[email protected]>
Done in commit c8b628d:
The unified FIO chart now supports testing any storage type through the |
|
@copilot in the fio example, blobfuse should not be an option - that can be used with the "existingPvcName" option |
Co-authored-by: edwardsp <[email protected]>
|
@copilot please resolve conflicts |
Co-authored-by: edwardsp <[email protected]>
|
@copilot It's still failing on linter checks |
Co-authored-by: edwardsp <[email protected]>
|
@copilot I've been testing and updating the branch but it is failing again on the yaml and markdown - can you fix again? |
Co-authored-by: edwardsp <[email protected]>
Fixed in commit 180ac0d. The issue was in
All linter checks now pass:
|
|
@copilot failing on markdown prettier: MARKDOWN_PRETTIER
|
Co-authored-by: edwardsp <[email protected]>
Add Azure Container Storage support and unified FIO testing tool
AZURE_CONTAINER_STORAGE_TYPEenvironment variableENABLE_AZURE_CONTAINER_STORAGEtotrueephemeralDiskparameter from--enable-azure-container-storageflaginfrastructure_validations/aks/blobfusetoinfrastructure_validations/aks/fioLatest Fix:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.