Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 14, 2025

Validated all internal markdown links and Helm parameters across the repository. Found and corrected mismatches between documented Helm commands and actual chart values.yaml files.

Fixed Internal Links

  • storage_references/aks/shared_storage/README.md: Corrected relative path to FIO documentation (../../../../../)

Fixed Helm Parameters

Storage Charts

  • AMLFS: storage.pvc.namestorage.pvcName
  • Blob: pvc.namestorage.pvcName
  • Applied across: examples/llm-foundry/aks/, examples/megatron-lm/GPT3-175B/aks/, storage_references/aks/shared_storage/

Megatron-LM (examples/megatron-lm/GPT3-175B/aks/README.md)

  • AMLFS: amlfs.skuNamestorage.amlfs.skuName, amlfs.storageCapacityTiBstorage.size
  • Chart paths: ../../../../../../../ (corrected directory traversal depth)
  • Model config: model.custom.numLayersmodel.numLayers (removed incorrect nesting)

Utilities

  • Torset labeler: nodepool.selectornodepool.selectorLabel

Example correction:

# Before (incorrect)
helm install shared-storage ../../../storage_references/aks/shared_storage/helm/amlfs-shared-storage \
  --set amlfs.skuName="AMLFS-Durable-Premium-125" \
  --set pvc.name="shared-storage-pvc"

# After (correct)  
helm install shared-storage ../../../../storage_references/aks/shared_storage/helm/amlfs-shared-storage \
  --set storage.amlfs.skuName="AMLFS-Durable-Premium-125" \
  --set storage.pvcName="shared-storage-pvc"

Validated: 26 markdown files, 28 Helm commands, 87 parameters

Original prompt

can you check all the internal links in the markdown readme files are correct? Also, make sure any helm parameters that are used in examples in the readme files are actually correct


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Check internal links and helm parameters in README Fix incorrect internal links and Helm parameters in README files Nov 14, 2025
Copilot AI requested a review from edwardsp November 14, 2025 10:54
@edwardsp edwardsp marked this pull request as ready for review November 14, 2025 13:28
@edwardsp edwardsp merged commit d40971a into main Nov 15, 2025
16 of 18 checks passed
@edwardsp edwardsp deleted the copilot/check-internal-links-readme branch November 15, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants