create session by browndav-msft · Pull Request #48639 · Azure/azure-sdk-for-java

browndav-msft · 2026-03-30T21:59:26Z

No description provided.

- downgrade blobserviceversion to 2026_04_06 - change AZURE_LIVE_TEST_SERVICE_VERSION to V2026_04_06 in ci.system.properties in azure-storage-common - create both sync and async

…p instead of ContainersImpl

…tainerapitests

…ationPolicy + AccessTokenCache pattern

…essions

…eAuthorizationPolicy

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 13 comments.

Copilot · 2026-04-20T18:07:11Z

 use: '@autorest/java@4.1.63'
-input-file: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/15d7f54a5389d5906ffb4e56bb2f38fe5525c0d3/specification/storage/data-plane/Microsoft.BlobStorage/stable/2026-06-06/blob.json
+input-file: https://raw.githubusercontent.com/nickliu-msft/azure-rest-api-specs/013866b01623e6f2cc6c313b44c9c6460de3e91e/specification/storage/data-plane/Microsoft.BlobStorage/stable/2026-10-06/blob.json
 java: true


The input-file points to a personal GitHub fork (nickliu-msft/azure-rest-api-specs) and references a future-dated spec folder (2026-10-06). This makes generation non-reproducible and likely breaks for others/CI; please point to an official Azure/azure-rest-api-specs commit and a spec version that exists there.

…/blob/implementation/util/BlobSessionClient.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 8 comments.

Copilot · 2026-04-20T23:39:20Z

+AZURE_LIVE_TEST_SERVICE_VERSION=V2026_04_06
 AZURE_STORAGE_SAS_SERVICE_VERSION=2026-06-06


AZURE_LIVE_TEST_SERVICE_VERSION was downgraded to V2026_04_06, but AZURE_STORAGE_SAS_SERVICE_VERSION remains 2026-06-06. Given this PR also removes 2026-06-06 from BlobServiceVersion, keeping the SAS service version on 2026-06-06 risks tests using a version that the client no longer recognizes/supports. Consider aligning AZURE_STORAGE_SAS_SERVICE_VERSION with the live test version (or documenting why it must remain newer).

Copilot · 2026-04-20T23:39:20Z

+        }
+
+        return new HttpPipelineBuilder().policies(policies.toArray(new HttpPipelinePolicy[0]))
+            .httpClient(basePipeline.getHttpClient())


wrapWithSessionPolicy rebuilds a new HttpPipeline but only carries over the HttpClient and policies. This drops pipeline-level configuration like the existing Tracer (and any initialization that depended on ClientOptions), and will reinitialize InstrumentationPolicy with default settings. Consider preserving basePipeline.getTracer() (and, if possible, the original ClientOptions), or avoid rebuilding the pipeline by delegating to the existing basePipeline after inserting the session auth behavior.

Suggested change

.httpClient(basePipeline.getHttpClient())

.httpClient(basePipeline.getHttpClient())

.tracer(basePipeline.getTracer())

Copilot · 2026-04-20T23:39:21Z

+    public void policyRefreshesNearExpiryWithoutBlockingSyncRequests() {
+        StorageSessionCredential nearExpiry = credentialWithToken(FIRST_TOKEN, OffsetDateTime.now().plusSeconds(2));
+        StorageSessionCredential refreshed = credentialWithToken(SECOND_TOKEN);
+
+        when(sessionClient.createSessionSync()).thenReturn(nearExpiry);
+        when(sessionClient.createSessionAsync()).thenReturn(Mono.just(refreshed));
+
+        StorageSessionCredential initial = policy.getValidSessionSync();
+        StorageSessionCredential duringRefresh = policy.getValidSessionSync();
+        StorageSessionCredential afterRefresh = policy.getValidSessionSync();
+
+        assertEquals(FIRST_TOKEN, initial.getSessionToken());
+        assertEquals(FIRST_TOKEN, duringRefresh.getSessionToken());
+        assertEquals(SECOND_TOKEN, afterRefresh.getSessionToken());
+        verify(sessionClient, times(1)).createSessionSync();


policyRefreshesNearExpiryWithoutBlockingSyncRequests asserts that the second getValidSessionSync() call returns the pre-refresh token, but refreshSessionInBackground() subscribes immediately. With a fast/inline createSessionAsync() (as in this mock), the refresh can complete before the second call, making the assertion timing-dependent and potentially flaky. Consider making the test tolerant to either outcome or explicitly controlling scheduling/completion of the refresh Mono.

Copilot · 2026-04-20T23:39:21Z

+        HttpPipelinePolicy capturePolicy = (context, next) -> {
+            String auth = context.getHttpRequest().getHeaders().getValue(HttpHeaderName.AUTHORIZATION);
+            if (auth != null) {
+                capturedAuthHeaders.add(auth);
+            }
+            return next.process();
+        };


The capturePolicy is added via builder.addPolicy(...), which defaults to a PER_CALL policy. In the pipeline, PER_CALL policies run before auth policies, so context.getHttpRequest().getHeaders().getValue(AUTHORIZATION) will still be null here and capturedAuthHeaders will remain empty, making the assertions below fail. To reliably capture the final Authorization header, capture it after next.process() (or set the policy position to PER_RETRY / after-auth).

Suggested change

HttpPipelinePolicy capturePolicy = (context, next) -> {

String auth = context.getHttpRequest().getHeaders().getValue(HttpHeaderName.AUTHORIZATION);

if (auth != null) {

capturedAuthHeaders.add(auth);

}

return next.process();

};

HttpPipelinePolicy capturePolicy = (context, next) -> next.process().doOnSuccess(response -> {

String auth = context.getHttpRequest().getHeaders().getValue(HttpHeaderName.AUTHORIZATION);

if (auth != null) {

capturedAuthHeaders.add(auth);

}

});

Copilot · 2026-04-20T23:39:21Z

+        List<HttpPipelinePolicy> bearerPolicies = new ArrayList<>(policies);
+        httpsValidation(tokenCredential, "bearer token", endpoint, logger);
+        String scope = audience != null
+            ? ((audience.toString().endsWith("/") ? audience + ".default" : audience + "/.default"))
+            : Constants.STORAGE_SCOPE;
+        bearerPolicies.add(new StorageBearerTokenChallengeAuthorizationPolicy(tokenCredential, scope));
+


In addSessionPolicyIfEnabled, the bearerPipeline used for CreateSession is built from the current policies list before later pipeline policies are appended (per-retry policies, after-retry providers like InstrumentationPolicy, response validation, logging, etc.). This means CreateSession requests may behave differently (missing retries/logging/validation) than normal requests. Consider building the bearer-only pipeline from the final policy list (minus the session policy) so CreateSession calls get the same cross-cutting behavior as other requests.

Copilot · 2026-04-20T23:39:21Z

+    @ServiceMethod(returns = ReturnType.SINGLE)
+    CreateSessionResponse createSession() {
+        return createSessionWithResponse(null, Context.NONE).getValue();


These createSession* methods are package-private even though they’re annotated with @ServiceMethod and return a generated implementation.models.* type. If Create Session is intended to be a customer-facing API, these should be public and ideally return a public model type; otherwise, consider removing @ServiceMethod to avoid implying a supported public surface.

Copilot · 2026-04-20T23:39:21Z

+        HttpPipelinePolicy capturePolicy = (context, next) -> {
+            String auth = context.getHttpRequest().getHeaders().getValue(HttpHeaderName.AUTHORIZATION);
+            if (auth != null) {
+                capturedAuthHeaders.add(auth);
+            }
+            return next.process();
+        };


The capturePolicy is added via builder.addPolicy(...), which defaults to a PER_CALL policy. In the pipeline, PER_CALL policies run before auth policies, so context.getHttpRequest().getHeaders().getValue(AUTHORIZATION) will still be null here and capturedAuthHeaders will remain empty, making the assertions below fail. To reliably capture the final Authorization header, capture it after next.process() (or set the policy position to PER_RETRY / after-auth).

Suggested change

HttpPipelinePolicy capturePolicy = (context, next) -> {

String auth = context.getHttpRequest().getHeaders().getValue(HttpHeaderName.AUTHORIZATION);

if (auth != null) {

capturedAuthHeaders.add(auth);

}

return next.process();

};

HttpPipelinePolicy capturePolicy = (context, next) -> next.process().doOnSuccess(ignored -> {

String auth = context.getHttpRequest().getHeaders().getValue(HttpHeaderName.AUTHORIZATION);

if (auth != null) {

capturedAuthHeaders.add(auth);

}

});

browndav-msft · 2026-04-21T20:42:26Z

/azp run java - pullrequest

azure-pipelines · 2026-04-21T20:42:33Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

ibrandes · 2026-04-21T21:10:05Z

/azp run java - storage - ci

azure-pipelines · 2026-04-21T21:10:12Z

No pipelines are associated with this pull request.

ibrandes · 2026-04-21T21:11:03Z

/azp run java - storage - tests

azure-pipelines · 2026-04-21T21:11:21Z

Azure Pipelines successfully started running 1 pipeline(s).

generate base files based on swagger docs

4c94ea6

github-actions Bot added the Storage Storage Service (Queues, Blobs, Files) label Mar 30, 2026

browndav-msft added 28 commits April 1, 2026 18:03

create live tests for createSession

d561535

- downgrade blobserviceversion to 2026_04_06 - change AZURE_LIVE_TEST_SERVICE_VERSION to V2026_04_06 in ci.system.properties in azure-storage-common - create both sync and async

add recordings

1020227

create new files based on swagger update

1d905f0

add two params to BlobContainerClient#createSessionWithResponse

9f8e365

add sanitizers for SessionToken and SessionKey to BlobTestBase

e63fe17

add recording for createSessionReturnsTokenAndKey

3e2fb11

create StorageSessionCredential with isExpired

3968a0e

create BlobSessionClient so that BlobSessionProvider takes it as a de…

09dcce6

…p instead of ContainersImpl

create BlobSEssionClient with tests

bea226b

add recorings for BlobSessionClient

e0b4440

fix BlobContainerAsyncClient to match new swagger, add new recording

0a3570e

add SessionProvider and SessionProviderTest

6a026f3

add accountName to BlobSessionClient

f6ca3e8

add accountName to StorageSessionCredential and SesionTestHelper

a1bdf3a

wip

7309432

change sessionprovider to SEssionTokenCredentialPolicy

9aa9bab

wip

8a620a1

move session tests from containerapi to blobsessionclienttests

925c44b

fix blobsessiontests and add place holder for end-to-end tests in con…

798b821

…tainerapitests

add recordings for blobsessionclient

ced6225

linting

a93e06a

refactor cache into separate class so it follows BearerTokenAuthentic…

301189a

…ationPolicy + AccessTokenCache pattern

add 503 fallback

9c3b2e3

add tests for udsas, but disabled for now

0e5a6b0

refactor createContext to use hardcoded endpoint

4cc43cf

add SessionMode and tests for SessionMode

b3a5774

add sessionOptions to buildPipeline, add null to builders not using s…

4c87689

…essions

move SessionTokenCredentialPolicy ahead of StorageBearerTokenChalleng…

7e5b122

…eAuthorizationPolicy

browndav-msft added 3 commits April 20, 2026 13:11

remove old SessionOptions

c2c10a5

remove unnecessary references to containerName and serviceVersion

9e5404a

add BlobContainerSessionInfo, add other Copilot recommendations

a147cc7

browndav-msft requested a review from Copilot April 20, 2026 17:55

Copilot started reviewing on behalf of browndav-msft April 20, 2026 17:56 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

browndav-msft and others added 7 commits April 20, 2026 16:01

delete BlobContainerSessionInfo, restore return CreateSessionResponse

e7c047e

create createSession end-to-end test with recordings

fc6ee15

only allow get requests for getblob

e157d96

wrap tests in try-with-resources

cba8194

make createSession package private

83e5710

fixes based on copilot suggestions

13e26be

Update sdk/storage/azure-storage-blob/src/main/java/com/azure/storage…

605a9cb

…/blob/implementation/util/BlobSessionClient.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

browndav-msft requested a review from Copilot April 20, 2026 23:29

Copilot started reviewing on behalf of browndav-msft April 20, 2026 23:30 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

add containerName to SessionOptions

08edd49

browndav-msft marked this pull request as ready for review April 21, 2026 19:47

browndav-msft requested review from a team, alzimmermsft, gunjansingh-msft, ibrandes, kyleknap and seanmcc-msft as code owners April 21, 2026 19:47

		AZURE_LIVE_TEST_SERVICE_VERSION=V2026_04_06
		AZURE_STORAGE_SAS_SERVICE_VERSION=2026-06-06

	.httpClient(basePipeline.getHttpClient())
	.httpClient(basePipeline.getHttpClient())
	.tracer(basePipeline.getTracer())

Conversation

browndav-msft commented Mar 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

browndav-msft commented Apr 21, 2026

Uh oh!

azure-pipelines Bot commented Apr 21, 2026

Uh oh!

ibrandes commented Apr 21, 2026

Uh oh!

azure-pipelines Bot commented Apr 21, 2026

Uh oh!

ibrandes commented Apr 21, 2026

Uh oh!

azure-pipelines Bot commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants