[AutoPR azure-resourcemanager-netapp]-generated-from-SDK Generation - Java-6180387#48871
[AutoPR azure-resourcemanager-netapp]-generated-from-SDK Generation - Java-6180387#48871
Conversation
…pp/NetApp/tspconfig.yaml', API Version: 2026-01-01, SDK Release Type: stable, and CommitSHA: 'c5044e9d381c2bf1b3119011b4696e777f819f76' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6180387 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
…pp/NetApp/tspconfig.yaml', API Version: 2026-01-01, SDK Release Type: stable, and CommitSHA: 'c5044e9d381c2bf1b3119011b4696e777f819f76' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6180465 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
ClusterPeerCommandResponse and SvmPeerCommandResponse change is the result of a bugfix. The model did not match the service behavior and was not working as modeled previously changed in TypeSpec. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the NetAppFiles management library to the 2026-01-01 API version and finalizes the 2.2.0 stable release output from the generator.
Changes:
- Bumps package to
2.2.0stable and updates package metadata to API version2026-01-01. - Removes a set of previously generated “Elastic*” and
ActiveDirectoryConfigsclient/model surfaces. - Reshapes select response models (e.g., peer command responses) to return a
propertiesobject and aligns cache listing APIs tolist(...).
Reviewed changes
Copilot reviewed 65 out of 589 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/ElasticVolumeImpl.java | Removed generated ElasticVolume implementation. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/ElasticSnapshotsImpl.java | Removed generated ElasticSnapshots collection implementation. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/ElasticSnapshotPolicyImpl.java | Removed generated ElasticSnapshotPolicy implementation. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/ElasticSnapshotPoliciesImpl.java | Removed generated ElasticSnapshotPolicies collection implementation. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/ElasticSnapshotImpl.java | Removed generated ElasticSnapshot implementation. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/ElasticCapacityPoolsImpl.java | Removed generated ElasticCapacityPools collection implementation. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/ElasticCapacityPoolImpl.java | Removed generated ElasticCapacityPool implementation. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/ElasticBackupsImpl.java | Removed generated ElasticBackups collection implementation. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/ElasticBackupVaultsImpl.java | Removed generated ElasticBackupVaults collection implementation. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/ElasticBackupVaultImpl.java | Removed generated ElasticBackupVault implementation. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/ElasticBackupPolicyImpl.java | Removed generated ElasticBackupPolicy implementation. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/ElasticBackupPoliciesImpl.java | Removed generated ElasticBackupPolicies collection implementation. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/ElasticBackupImpl.java | Removed generated ElasticBackup implementation. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/ElasticAccountsImpl.java | Removed generated ElasticAccounts collection implementation. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/ElasticAccountImpl.java | Removed generated ElasticAccount implementation. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/ClusterPeerCommandResponseImpl.java | Switches surface from peerAcceptCommand() to properties(). |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/CheckElasticResourceAvailabilityResponseImpl.java | Removed generated wrapper implementation. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/CachesImpl.java | Renames cache listing to list(...). |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/CachesClientImpl.java | Renames service methods and paging helpers to list*/listNext*. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/ActiveDirectoryConfigsImpl.java | Removed generated ActiveDirectoryConfigs collection implementation. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/implementation/ActiveDirectoryConfigImpl.java | Removed generated ActiveDirectoryConfig implementation. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/VolumeProperties.java | Removes several serialized fields and adjusts quota Javadoc text. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/VolumePatchProperties.java | Adjusts quota Javadoc text. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/VolumeInner.java | Aligns volume Javadoc text and removes pass-through accessors for removed fields. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/SvmPeerCommandResponseInner.java | Changes response wire format to a properties object. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/PoolProperties.java | Updates pool size Javadoc text. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/PoolPatchProperties.java | Updates pool size Javadoc text. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/NetAppAccountInner.java | Removes pass-through accessors for Entra ID and LDAP configuration. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/ElasticVolumeInner.java | Removed generated ElasticVolume wire model. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/ElasticSnapshotPolicyInner.java | Removed generated ElasticSnapshotPolicy wire model. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/ElasticSnapshotInner.java | Removed generated ElasticSnapshot wire model. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/ElasticCapacityPoolInner.java | Removed generated ElasticCapacityPool wire model. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/ElasticBackupVaultInner.java | Removed generated ElasticBackupVault wire model. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/ElasticBackupPolicyInner.java | Removed generated ElasticBackupPolicy wire model. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/ElasticBackupInner.java | Removed generated ElasticBackup wire model. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/ElasticAccountInner.java | Removed generated ElasticAccount wire model. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/ClusterPeerCommandResponseInner.java | Changes response wire format to a properties object. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/CheckElasticResourceAvailabilityResponseInner.java | Removed generated Elastic availability response wire model. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/CapacityPoolInner.java | Updates pool size Javadoc text. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/ActiveDirectoryConfigInner.java | Removed generated ActiveDirectoryConfig wire model. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/AccountPropertiesPatch.java | Removed generated PATCH properties model. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/models/AccountProperties.java | Removes Entra ID and LDAP configuration fields from account properties model. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/NetAppManagementClient.java | Removes getters for Elastic* and ActiveDirectoryConfigs clients. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/ElasticSnapshotsClient.java | Removed ElasticSnapshots client interface. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/ElasticAccountsClient.java | Removed ElasticAccounts client interface. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/CachesClient.java | Renames cache list APIs to list(...). |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/fluent/ActiveDirectoryConfigsClient.java | Removed ActiveDirectoryConfigs client interface. |
| sdk/netapp/azure-resourcemanager-netapp/src/main/java/com/azure/resourcemanager/netapp/NetAppFilesManager.java | Removes Elastic* and ActiveDirectoryConfigs entry points from the manager. |
| sdk/netapp/azure-resourcemanager-netapp/pom.xml | Sets stable version 2.2.0, updates description API version, and enables revapi by removing skip. |
| sdk/netapp/azure-resourcemanager-netapp/README.md | Updates API version and dependency version to 2.2.0. |
| sdk/netapp/azure-resourcemanager-netapp/CHANGELOG.md | Adds 2.2.0 release notes and highlights some changes. |
| eng/versioning/version_client.txt | Updates tracked artifact version to 2.2.0. |
| * to 2400TiB. | ||
| * For extra large volumes, valid values are in the range 2400GiB to 7200TiB. Values expressed in bytes as multiples | ||
| * regular volumes, valid values are in the range 50GiB to 100TiB. For large volumes, valid values are in the range | ||
| * 100TiB to 500TiB, and on an exceptional basis, from to 2400GiB to 2400TiB. Values expressed in bytes as multiples |
There was a problem hiding this comment.
Fix grammar in Javadoc: change 'from to 2400GiB' to 'from 2400GiB'.
| * 100TiB to 500TiB, and on an exceptional basis, from to 2400GiB to 2400TiB. Values expressed in bytes as multiples | |
| * 100TiB to 500TiB, and on an exceptional basis, from 2400GiB to 2400TiB. Values expressed in bytes as multiples |
| #### `models.SvmPeerCommandResponse` was modified | ||
|
|
||
| ### Other Changes | ||
| * `svmPeeringCommand()` was removed | ||
|
|
||
| #### `models.ClusterPeerCommandResponse` was modified | ||
|
|
||
| * `peerAcceptCommand()` was removed |
There was a problem hiding this comment.
I see the breaks come from https://github.com/Azure/azure-rest-api-specs/pull/42162/changes#diff-19f0e3674bac3b097417dbbbd5966043164252f8f4f9d64ecb72653550a30496
Is there a mitigation (in client.tsp) possible? E.g. is peerAcceptCommand intended be the same as properties.clusterPeeringCommand?
There was a problem hiding this comment.
ClusterPeerCommandResponse and SvmPeerCommandResponse change is the result of a bugfix. The model did not match the service behavior and was not working as modeled previously changed in TypeSpec.
peerAcceptCommand is same as peerAcceptCommand but passphrase was also required.
Not sure if this can be mitigated in TypeSpec.
Configurations: 'specification/netapp/resource-manager/Microsoft.NetApp/NetApp/tspconfig.yaml', API Version: 2026-01-01, SDK Release Type: stable, and CommitSHA: 'c5044e9d381c2bf1b3119011b4696e777f819f76' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6180387 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=40b8b7c1-3d37-f111-88b5-000d3a5c49ca Submitted by: b-aubald@microsoft.com
Release Plan Details
Spec pull request: [NetAppFiles] Release microsoft.net app 2026 01 01 azure-rest-api-specs#42162
Spec API version: 2026-01-01