Move Storage Extension to Use Pyproject.toml#47351
Open
kashifkhan wants to merge 2 commits into
Open
Conversation
kashifkhan
requested review from
annatisch,
jalauzon-msft,
vincenttran-msft and
weirongw23-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the azure-storage-extensions package’s packaging metadata from setup.py into pyproject.toml, while keeping a minimal setup.py to support building the C extension and producing abi3-tagged wheels.
Changes:
- Added full PEP 621 project/build metadata to
pyproject.toml(including dynamic version/readme configuration). - Simplified
setup.pyto only define the limited-API C extension and overridebdist_wheeltagging toabi3. - Added
[tool.azure-sdk-conda]metadata for the package.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/storage/azure-storage-extensions/setup.py | Reduced to only extension build + bdist_wheel abi3 tag override, relying on pyproject.toml for metadata. |
| sdk/storage/azure-storage-extensions/pyproject.toml | Introduces build-system + project metadata and setuptools dynamic configuration, plus conda metadata. |
weirongw23-msft
approved these changes
Jun 4, 2026
| ] | ||
|
|
||
| [tool.setuptools.package-data] | ||
| "azure.storage.extensions.checksums" = ["py.typed", "*.pyi"] |
Member
There was a problem hiding this comment.
This shouldn't be needed as I believe setuptools picks these by default. You can try removing and checking the wheel contents
kashifkhan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving storage extensions to use pyproject.toml.
setup.pyremains since building extensions is marked as experiment for pyproject.toml