-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Enable CFSClean network isolation for Python pipelines #48483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Daniel Jurek (danieljurek)
wants to merge
17
commits into
main
Choose a base branch
from
djurek/python-cfs-compliance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3517872
Point PIP_EXTRA_INDEX_URL at the CFS feed instead of public PyPI
danieljurek c3a62f7
TEMP: touch azure-core-tracing-opentelemetry to force package targeting
danieljurek 5582f0c
Set CFSClean for pipelines
danieljurek 4f72fc1
Test change to trigger build of keyvault package
danieljurek 14a2b23
Revert "TEMP: touch azure-core-tracing-opentelemetry to force package…
danieljurek e17d5ff
Revert "Test change to trigger build of keyvault package"
danieljurek 854d88f
Remove the PIP_EXTRA_INDEX_URL default and defer to PIP_INDEX_URL
danieljurek 55a7999
TEMP: touch azure-keyvault-secrets to force package targeting
danieljurek 4c59003
TEMP: touch READMEs to exercise CI across three package shapes
danieljurek ed6af23
TEMP: drop the azure-core README touch to avoid the mindependency fanout
danieljurek 7fdc433
Disable mindependency checks for CFS onboarding; restore azure-core t…
danieljurek 4c3e134
Revert TEMP README touches used to force package targeting
danieljurek f417ce1
Authenticate conda pipelines against the CFS feed
danieljurek e9d4347
Resolve conda sdists through the configured package index
danieljurek 3d00565
Exempt the conda pipelines from CFSClean network isolation
danieljurek 98f2d03
Revert conda CFSClean carve-out
danieljurek 66d7971
Gate conda index downloads on from_package_index
danieljurek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking the fix — gated on
from_package_indexin 66d7971.One correction to the framing though: this is not a regression from this PR. The outer condition is unchanged by my commit — it read
download_uri or versionbefore and after (seee9d4347150^). Anddownload_uriwas only ever populated whencheckout_path is None:from_package_indexcarries that identical predicate, so checkout-backed configs reached this same branch previously — they just arrived withdownload_uri=Noneand died indownload_pypi_sourceatos.path.basename(None)with aTypeError.So the real change is loud crash → silently downloading from the index, which is the worse of the two, and the suggested gate is the right repair for a pre-existing bug:
checkout_path+versionnow falls through toget_git_source, matching what the config schema and theValueErrormessage both document.Latent either way — no conda configuration in the repo sets
checkout_path(0 occurrences across all YAML). Verified all four config shapes route correctly after the change.