Abort tests in case of go-vcr failure #5067
Open
+168
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
jakjang,
juan-lee and
matthchr
as code owners
github-project-automation
bot
moved this to In Progress
in Azure Service Operator Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
We're seeing an increasing number of test failures where a particular resource gets stuck in a non-terminal condition, leaving the test to iterate in place until it times out. This failure mode means that it takes a long time to iterate on fixes - CI can take over an hour to run, most of that time spent in a failed condition.
This PR makes changes to improve reliability of tests, and to ensure failed tests terminate quickly - these should make it easier to iterate on fixes for remaining underlying issues.
Creating,Deleting,InProgress, etc)TEST-REQUEST-ATTEMPTheader when matching requests (this was needed for go-vcr v1 but not for newer versions)Eventually()wait ifgo-vcrdoesn't find a response to playbackHow does this PR make you feel?