Skip to content

Conversation

@comtalyst
Copy link
Collaborator

@comtalyst comtalyst commented Sep 16, 2025

Fixes #

Description

Add a script to add AKS machines pool to a cluster, being used directly in development. Currently not being used by any other command yet. To be a part of Machine API integration.

Note the unavailability of CLI, thus the need to use Azure REST.

How was this change tested?

  • Manually

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@comtalyst comtalyst added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 17, 2025
Copy link
Contributor

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason to do this outside of the makefile.az pattern we have been doing for all other setup steps?

@comtalyst
Copy link
Collaborator Author

comtalyst commented Sep 17, 2025

is there a reason to do this outside of the makefile.az pattern we have been doing for all other setup steps?

This piece is just a quick dev tool. Integration with Makefile is more coupled to the existence of Machine API integration itself in the current plan (see #1102). It would be in a different PR.

@matthchr
Copy link
Member

Even the makefile sometimes shells out to individual scripts, no?

@comtalyst
Copy link
Collaborator Author

comtalyst commented Sep 18, 2025

Even the makefile sometimes shells out to individual scripts, no?

Yes. Though it is more that Makefile is a higher-level interface, and I think we should try to keep it "clean"--to reserve it for more-production-ready things. The list of files in this folder, on the other hand, is at lower level, so adding this less-relevant-to-production-Karpenter tool wouldn't hurt.

See #1197

@comtalyst comtalyst force-pushed the comtalyst/hack-deploy-add-machines-pool branch from 3594fba to b6fdac9 Compare October 1, 2025 21:05
@comtalyst comtalyst merged commit e4199a8 into main Oct 8, 2025
23 of 26 checks passed
@comtalyst comtalyst deleted the comtalyst/hack-deploy-add-machines-pool branch October 8, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants