-
Notifications
You must be signed in to change notification settings - Fork 100
feat: a script to add AKS machines pool to a cluster #1158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bryce-Soghigian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason to do this outside of the makefile.az pattern we have been doing for all other setup steps?
This piece is just a quick dev tool. Integration with Makefile is more coupled to the existence of Machine API integration itself in the current plan (see #1102). It would be in a different PR. |
|
Even the makefile sometimes shells out to individual scripts, no? |
Yes. Though it is more that Makefile is a higher-level interface, and I think we should try to keep it "clean"--to reserve it for more-production-ready things. The list of files in this folder, on the other hand, is at lower level, so adding this less-relevant-to-production-Karpenter tool wouldn't hurt. See #1197 |
3594fba to
b6fdac9
Compare
Fixes #
Description
Add a script to add AKS machines pool to a cluster, being used directly in development. Currently not being used by any other command yet. To be a part of Machine API integration.
Note the unavailability of CLI, thus the need to use Azure REST.
How was this change tested?
Does this change impact docs?
Release Note