Add PerfTrace API and add tracing to XmlHttpRequest#125
Merged
ryantrem merged 7 commits intoBabylonJS:mainfrom Nov 14, 2025
Merged
Add PerfTrace API and add tracing to XmlHttpRequest#125ryantrem merged 7 commits intoBabylonJS:mainfrom
ryantrem merged 7 commits intoBabylonJS:mainfrom
Conversation
Add some more tracing in XmlHttpRequest
ryantrem
commented
Nov 14, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds a platform-agnostic PerfTrace API that wraps arcana's trace_region functionality and integrates performance tracing into XMLHttpRequest operations. The implementation depends on updates to the upstream arcana.cpp library.
- Introduces a new
PerfTraceAPI with configurable trace levels and handle management - Adds performance tracing to XMLHttpRequest's
SendandRaiseEventmethods - Updates CMake configuration to link Foundation library with required dependencies
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| Core/Foundation/Include/Babylon/PerfTrace.h | Declares the public PerfTrace API with Level enum and Handle class |
| Core/Foundation/Source/PerfTrace.cpp | Implements PerfTrace API with arcana trace_region wrapping and Napi interop |
| Core/Foundation/CMakeLists.txt | Adds PerfTrace files and links Foundation with napi and arcana dependencies |
| Polyfills/XMLHttpRequest/Source/XMLHttpRequest.h | Adds m_url member to store URL for tracing purposes |
| Polyfills/XMLHttpRequest/Source/XMLHttpRequest.cpp | Integrates tracing into Send and RaiseEvent operations |
| CMakeLists.txt | Updates arcana.cpp dependency to personal fork with tracing support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bghgary
requested changes
Nov 14, 2025
bghgary
approved these changes
Nov 14, 2025
ryantrem
added a commit
to BabylonJS/BabylonNative
that referenced
this pull request
Nov 15, 2025
…JsRuntime's Foundation lib (#1569) This PR depends on BabylonJS/JsRuntimeHost#125 - Rework NativeTracing to be build on top of the new PerfTrace helper from JsRuntime's Foundation lib. - Add NativeTracing to the iOS app (the platform tracing is currently implemented for). - Add a commented out line in experience.js that enables tracing through the Babylon.js API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on microsoft/arcana.cpp#51