Closes #5366: arkouda.core module#5367
Conversation
d3e1a88 to
c8c34ff
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5367 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 5
Lines ? 115
Branches ? 0
========================================
Hits ? 115
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c8c34ff to
365b0d1
Compare
9cc6aa3 to
a125c76
Compare
drculhane
left a comment
There was a problem hiding this comment.
I like this change. Definitely an improvement. As a test, in array_api/manipulation_functions.py, I commented out all of the imports of generic_msg, and put just one import at the top of the file. It worked, with no circular import error.
The same thing didn't work in core/logger. I did get a circular import error there.
That's my whole experience. I didn't try an exhaustive check of where we can move the import to the top vs where we still can't.
a125c76 to
c8d6755
Compare
c8d6755 to
81333c1
Compare
Summary
This PR completes the migration of client-facing internals from legacy top-level modules
(
arkouda.client,arkouda.logger,arkouda.message,arkouda.infoclass,arkouda.security)into the new
arkouda.core.*namespace.All internal imports, tests, benchmarks, documentation, and configuration have been updated
to reference
arkouda.coreas the authoritative implementation, while preserving backwardcompatibility via deprecation shims.
What changed
Core refactor & API usage
arkouda.client→arkouda.core.clientarkouda.logger→arkouda.core.loggerarkouda.message→arkouda.core.messagearkouda.infoclass→arkouda.core.infoclassarkouda.security→arkouda.core.securitygeneric_msg_no_opmaxTransferBytesto route through
arkouda.core.client.Deprecation shims
__init__.pyshims for:arkouda.core.clientarkouda.infoclassarkouda.loggerarkouda.messagearkouda.core.securityDeprecationWarningarkouda.core.*moduleTests & benchmarks
tests/core/pytest.inito include new core test paths and remove deprecated onesak.core.clientDocumentation & examples
arkouda.core.clientTooling & coverage
.coveragercand.flake8to reflect the new module layoutWhy this change
Backward compatibility
arkouda.client,arkouda.logger, etc. continue to workDeprecationWarnings guiding them toarkouda.core.*Follow-ups (out of scope)
Closes #5366: arkouda.core module