Merged
Conversation
awilfox
reviewed
Mar 6, 2026
Member
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
Couple of questions, but overall looks like a great change.
|
|
||
| # First load all UCPath Employee Data into obj | ||
| # rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/PerceivedComplexity, Metrics/CyclomaticComplexity | ||
| # |
Contributor
Author
There was a problem hiding this comment.
I'll tweak that with my next code change which will be touching on the user.rb file
| dbdef: "VARCHAR(16)" | ||
| status: OPTIONAL | ||
|
|
||
| - name: job_code |
Member
There was a problem hiding this comment.
Is this a related change? Why are these fields being removed? (should this be a separate change?)
Contributor
Author
There was a problem hiding this comment.
I had 2 duplicate codes (job_code and dept_code...guessing a copy/paste error ages ago). Structs are more strict than ostructs caught the issue.
davezuckerman
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.