Make compatible with OCaml 5 and Ghidra 11.4#1632
Draft
PerfectLaugh wants to merge 23 commits intoBinaryAnalysisPlatform:masterfrom
Draft
Make compatible with OCaml 5 and Ghidra 11.4#1632PerfectLaugh wants to merge 23 commits intoBinaryAnalysisPlatform:masterfrom
PerfectLaugh wants to merge 23 commits intoBinaryAnalysisPlatform:masterfrom
Conversation
This commit includes pinning to OCaml-5 compatible typerep (Currently it is broken due to getting reverted), renaming variables and types that using `effect` to `effect_` and janestreet packages update remove warnings in release mode: mainly label-missings
Author
|
This PR still contains several blocking issues:
|
|
cc @ivg |
|
@ivg Do you think you will have time to take a look? |
To compile with 5.4.0, this is necessary to use newest package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to be an ongoing effort of #1621
corelibrary should have version tagged with it but I currently leave it blank.