fix: assign config flags directly in API.__init__ (#5)#135
Merged
Conversation
…it__ Params were hardcoded to None/False then conditionally overwritten below; collapse to direct assignment. Same behavior, no dead override dance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First of 4 small, independent PRs cleaning up the hand-written SDK surface (issues #1–#5 from a structure review). This one fixes the config-ordering smell in
API.__init__.proxies,show_limit_usage, andshow_headerwere hardcoded toNone/False, then conditionally overwritten byifblocks lower in the constructor. Collapsed to direct assignment from the params.proxies→ kept thetype(proxies) is dictguard, inlineshow_limit_usage/show_header→bool(...)(wasis True; now also accepts truthy, which is friendlier)No behavior change for existing callers passing bools/dicts.
Tests
pytest -m "not integration": 134 passed, 11 skippeddatamaxi/api.pyKnown failures
None.