-
Notifications
You must be signed in to change notification settings - Fork 25
Bug/jet trace #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/jet trace #198
Conversation
03f3f17 to
98e10c5
Compare
|
Could you bump the patch version pls? |
bumped to 0.4.1 |
4eaed9d to
46a413c
Compare
KyrylR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 46a413c
|
@topologoanatom Commits should be signed |
46a413c to
11a03ba
Compare
KyrylR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 11a03ba
|
Heads up that 352b58b does not pass tests. This makes bisecting the repo harder. Broken unit tests should be annotated with @KyrylR thanks for tagging and publishing -- FYI I usually post a comment saying that I did so, because it's easy to forget. |
|
I would also prefer that the PR description describe what's going on -- that we are changing our heuristic for removing debug wrappers in our trace logic, that this is not a great solution but in #197 we agreed it was a good thing to do for now, and that there is a version bump in this PR. |
|
Version bumps should also have a CHANGELOG entry. It looks like this release included both this PR and #187 (as well as some admin stuff that doesn't need to be in the changelog). |
|
Ohh, sorry, I got it Basically, because we added a reproduction test in 352b58b and did not immediately implement a fix, local tests failed I will create a new PR to update the CHANGELOG a little bit later |
|
Updated CHANGELOG #215 |
Fixes: #197
Description
Changing the heuristics for removing debug wrappers inside the
jetresult parser.This approach is fragile, but it will suffice until the assertl-based debugging strategy is replaced.