[PW_SID:1053062] [RFC] bluetooth: remove all PCMCIA drivers#3301
[PW_SID:1053062] [RFC] bluetooth: remove all PCMCIA drivers#3301BluezTestBot wants to merge 3 commits intoworkflowfrom
Conversation
Add a check for the user-provided length in mgmt_mesh_add() against the size of the param buffer. This prevents a heap buffer overflow if the user provides a length larger than the destination buffer. Fixes: b338d91 ("Bluetooth: Implement support for Mesh") Cc: stable@vger.kernel.org Signed-off-by: Maiquel Paiva <maiquelpaiva@gmail.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This patch adds workflow files for ci: [sync.yml] - The workflow file for scheduled work - Sync the repo with upstream repo and rebase the workflow branch - Review the patches in the patchwork and creates the PR if needed [ci.yml] - The workflow file for CI tasks - Run CI tests when PR is created Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
PCMCIA is almost completely obsolete (the last computers supporting it natively were from ~2009), and the general consensus [1] seems to be that support for it should be gradually removed from the kernel. In 2023, an initial step of removing all the PCMCIA char drivers was taken in commit 9b12f05 ("char: pcmcia: remove all the drivers"), and that has not been reverted, so it seems logical to continue this process by removing more low-hanging fruit. These three Bluetooth drivers have had no meaningful changes since their status was discussed in 2022 [2], and are unlikely to have any remaining users. The latest functional change to any of them was a patch to bluecard_cs to fix LED blinking behavior in 2017. The other two drivers have not had any meaningful changes made since 2007. Remove them. Note that even with these drivers removed, it is still possible to use other PCMCIA Bluetooth cards that present themselves as a standard serial port via serial_cs and hciattach while the serial_cs driver is still present. [1] https://lore.kernel.org/all/c5b39544-a4fb-4796-a046-0b9be9853787@app.fastmail.com/ [2] https://lore.kernel.org/all/Y07d7rMvd5++85BJ@owl.dominikbrodowski.net/ Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
|
CheckPatch |
|
GitLint |
|
SubjectPrefix |
|
BuildKernel |
|
CheckAllWarning |
|
CheckSparse |
|
BuildKernel32 |
|
TestRunnerSetup |
|
TestRunner_l2cap-tester |
|
TestRunner_iso-tester |
|
TestRunner_bnep-tester |
|
TestRunner_mgmt-tester |
|
TestRunner_rfcomm-tester |
|
TestRunner_sco-tester |
|
TestRunner_ioctl-tester |
|
TestRunner_mesh-tester |
|
TestRunner_smp-tester |
|
TestRunner_userchan-tester |
|
IncrementalBuild |
github-actions
bot
force-pushed
the
workflow
branch
3 times, most recently
from
b12713f to
208468a
Compare
github-actions
bot
force-pushed
the
workflow
branch
5 times, most recently
from
3db96fb to
620c8d9
Compare
github-actions
bot
force-pushed
the
workflow
branch
from
620c8d9 to
07fb4f1
Compare
3 participants
PCMCIA is almost completely obsolete (the last computers supporting it
natively were from ~2009), and the general consensus [1] seems to be
that support for it should be gradually removed from the kernel.
In 2023, an initial step of removing all the PCMCIA char drivers was
taken in commit 9b12f05 ("char: pcmcia: remove all the drivers"),
and that has not been reverted, so it seems logical to continue this
process by removing more low-hanging fruit.
These three Bluetooth drivers have had no meaningful changes since
their status was discussed in 2022 [2], and are unlikely to have any
remaining users. The latest functional change to any of them was a
patch to bluecard_cs to fix LED blinking behavior in 2017. The other
two drivers have not had any meaningful changes made since 2007. Remove
them.
Note that even with these drivers removed, it is still possible to use
other PCMCIA Bluetooth cards that present themselves as a standard
serial port via serial_cs and hciattach while the serial_cs driver is
still present.
[1] https://lore.kernel.org/all/c5b39544-a4fb-4796-a046-0b9be9853787@app.fastmail.com/
[2] https://lore.kernel.org/all/Y07d7rMvd5++85BJ@owl.dominikbrodowski.net/
Signed-off-by: Ethan Nelson-Moore enelsonmoore@gmail.com
arch/arm/configs/pxa_defconfig | 3 -
arch/arm/configs/spitz_defconfig | 3 -
arch/loongarch/configs/loongson32_defconfig | 3 -
arch/loongarch/configs/loongson64_defconfig | 3 -
arch/mips/configs/mtx1_defconfig | 3 -
arch/powerpc/configs/ppc6xx_defconfig | 3 -
drivers/bluetooth/Kconfig | 40 -
drivers/bluetooth/Makefile | 3 -
drivers/bluetooth/bluecard_cs.c | 908 --------------------
drivers/bluetooth/bt3c_cs.c | 749 ----------------
drivers/bluetooth/dtl1_cs.c | 614 -------------
11 files changed, 2332 deletions(-)
delete mode 100644 drivers/bluetooth/bluecard_cs.c
delete mode 100644 drivers/bluetooth/bt3c_cs.c
delete mode 100644 drivers/bluetooth/dtl1_cs.c