fix: update tests for admin-auth-required GET endpoints (PR #6197 reviewer feedback)

.claude/skills/rtc-balance/SKILL.md

@@ -0,0 +1,98 @@
+---
+name: rtc-balance
+description: Check RustChain wallet balance, epoch info, and network status via the public RPC
+author: Emanon4
+tags: [rustchain, cryptocurrency, wallet, balance-checker]
+---
+
+# /rtc-balance — RustChain Wallet Balance Checker
+
+## Installation
+
+Copy this folder (`.claude/skills/rtc-balance/`) into your project's `.claude/skills/` directory. Claude Code automatically loads skills from that path.
+
+```
+mkdir -p .claude/skills
+cp -r path/to/rtc-balance .claude/skills/rtc-balance
+```
+
+Requires `curl` (pre-installed on macOS and most Linux distributions). No additional dependencies.
+
+## Usage
+
+```
+/rtc-balance <wallet_name>
+```
+
+`<wallet_name>` is your RustChain wallet address or miner ID.
+
+## Procedure (executed on invocation)
+
+When invoked with `<wallet_name>`, perform these steps in order:
+
+### Step 1 — Fetch wallet balance
+
+```
+curl -sS --max-time 8 "https://rustchain.org/wallet/balance?miner_id=<wallet_name>"
+```
+
+Parse the JSON response:
+- If the response contains `"amount_rtc"`: extract that float value as the balance
+- If the response is empty or `curl` exits non-zero: the node is unreachable, skip to Step 3a
+
+### Step 2 — Fetch network status
+
+```
+curl -sS --max-time 8 "https://rustchain.org/epoch"
+```
+
+Parse the JSON response for these fields:
+- `epoch`: int — current epoch number
+- `slot`: int — current slot within the epoch
+- `enrolled_miners`: int — number of active miners
+
+### Step 3a — Node offline path
+
+If Step 1 or Step 2 failed (curl timeout or non-JSON response):
+
+```
+Error: Node unreachable
+Check your network connection or try again later.
+```
+
+### Step 3b — Success path
+
+Format and print the output:
+
+```
+Wallet: <wallet_name>
+Balance: <amount_rtc> RTC ($<usd> USD)
+Epoch: <epoch> | Slot: <slot> | Miners online: <count>
+```
+
+Where:
+- `amount_rtc` = float from Step 1 (default `0.0` if wallet not found)
+- `usd` = `amount_rtc * 0.10` (reference rate: 1 RTC = $0.10 USD)
+- `epoch`, `slot`, `enrolled_miners` = integers from Step 2
+
+### Error handling
+
+| Scenario | Behavior |
+|----------|----------|
+| Wallet not found (API returns `{"amount_rtc": 0.0}`) | Show 0.00 RTC, continue |
+| Node unreachable | Stop, print "Node unreachable" message |
+| Empty wallet name | Print "Usage: /rtc-balance <wallet_name>" |
+
+## Example
+
+```
+/rtc-balance Emanon4
+```
+
+Expected output:
+
+```
+Wallet: Emanon4
+Balance: 0.00 RTC ($0.00 USD)
+Epoch: 162 | Slot: 23411 | Miners online: 14
+```

.github/FUNDING.yml

@@ -1,3 +1,2 @@
 github: [Scottcjn]
 ko_fi: elyanlabs
-custom: ["https://rustchain.elyanlabs.ai/donate"]

.github/actions/bcos-action/README.md

@@ -31,7 +31,7 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Run BCOS Scan
-        uses: Scottcjn/bcos-action@v1
+        uses: Scottcjn/Rustchain/.github/actions/bcos-action@main
         id: bcos
         with:
           tier: L1
@@ -59,7 +59,7 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Run BCOS L2 Scan
-        uses: Scottcjn/bcos-action@v1
+        uses: Scottcjn/Rustchain/.github/actions/bcos-action@main
         id: bcos
         with:
           tier: L2
@@ -78,7 +78,7 @@ jobs:
 
 ```yaml
 - name: Scan Subdirectory
-  uses: Scottcjn/bcos-action@v1
+  uses: Scottcjn/Rustchain/.github/actions/bcos-action@main
   with:
     repo-path: ./packages/core
     tier: L1
@@ -191,5 +191,5 @@ MIT License - see [LICENSE](LICENSE) file.
 ## Support
 
 - Documentation: https://rustchain.org/bcos/
-- Issues: https://github.com/Scottcjn/bcos-action/issues
+- Issues: https://github.com/Scottcjn/Rustchain/issues
 - Spec: https://github.com/Scottcjn/Rustchain/blob/main/docs/BEACON_CERTIFIED_OPEN_SOURCE.md

.github/actions/bcos-action/anchor.py

@@ -6,13 +6,20 @@
 """
 
 import json
+import logging
 import os
 from urllib.request import Request, urlopen
 from urllib.error import HTTPError
 
+logger = logging.getLogger("bcos-action")
+
 
 def main():
     """Anchor the BCOS attestation to RustChain."""
+    logging.basicConfig(
+        level=logging.INFO,
+        format="%(levelname)s %(name)s: %(message)s"
+    )
     # Get inputs from environment
     node_url = os.environ.get("INPUT_NODE_URL", "https://rustchain.org")
     cert_id = os.environ.get("CERT_ID", "")
@@ -22,7 +29,7 @@ def main():
     merged_commit = os.environ.get("MERGED_COMMIT", "")
 
     if not all([cert_id, commitment, repo, pr_number, merged_commit]):
-        print("⚠️ Missing required environment variables. Skipping anchor.")
+        logger.warning("Missing required environment variables. Skipping anchor.")
         return
 
     # Build attestation payload
@@ -51,16 +58,16 @@ def main():
     try:
         response = urlopen(req)
         result = json.loads(response.read().decode('utf-8'))
-        print(f"✅ Attestation anchored successfully!")
-        print(f"Transaction: {result.get('tx_hash', 'N/A')}")
-        print(f"Block: {result.get('block_number', 'N/A')}")
+        logger.info("Attestation anchored successfully!")
+        logger.info("Transaction: %s", result.get("tx_hash", "N/A"))
+        logger.info("Block: %s", result.get("block_number", "N/A"))
     except HTTPError as e:
         error_body = e.read().decode() if e.fp else ""
-        print(f"⚠️ Failed to anchor: {e.code}")
+        logger.error("Failed to anchor: %s", e.code)
         if error_body:
-            print(f"Response: {error_body}")
+            logger.debug("Response: %s", error_body)
     except Exception as e:
-        print(f"⚠️ Anchor skipped (node may be unavailable): {e}")
+        logger.warning("Anchor skipped (node may be unavailable): %s", e)
 
 
 if __name__ == "__main__":

.github/actions/bcos-action/main.py

@@ -234,7 +234,7 @@ def post_github_comment(repo: str, pr_number: str, report: dict, token: str) ->
 </details>
 
 ---
-*Generated by [BCOS v2 Action](https://github.com/Scottcjn/bcos-action)*
+*Generated by [BCOS v2 Action](https://github.com/Scottcjn/Rustchain/tree/main/.github/actions/bcos-action)*
 """
 
     api_url = f"https://api.github.com/repos/{repo}/issues/{pr_number}/comments"

.github/actions/bcos-action/post_comment.py

@@ -95,7 +95,7 @@ def main():
 </details>
 
 ---
-*Generated by [BCOS v2 Action](https://github.com/Scottcjn/bcos-action)*
+*Generated by [BCOS v2 Action](https://github.com/Scottcjn/Rustchain/tree/main/.github/actions/bcos-action)*
 """
 
     # Post to GitHub API

.github/actions/bcos-action/test_action.py

@@ -5,6 +5,7 @@
 Tests the main.py action script functionality.
 """
 
+import base64
 import json
 import os
 import sys
@@ -22,11 +23,16 @@
     anchor_to_rustchain,
     set_github_output
 )
+import post_comment as post_comment_script
+
+
+BCOS_ACTION_URL = "https://github.com/Scottcjn/Rustchain/tree/main/.github/actions/bcos-action"
+DEAD_BCOS_ACTION_URL = "https://github.com/Scottcjn/bcos-action"
 
 
 class TestMinimalBCOSScanner(unittest.TestCase):
     """Test the minimal BCOS scanner."""
-    
+
     def setUp(self):
         """Create a temporary test repository."""
         self.temp_dir = tempfile.TemporaryDirectory()
@@ -145,15 +151,9 @@ def test_cert_id_format(self):
 
 class TestGitHubComment(unittest.TestCase):
     """Test GitHub comment posting."""
-
-    @patch('main.urlopen')
-    def test_post_comment_success(self, mock_urlopen):
-        """Test successful comment posting."""
-        mock_response = MagicMock()
-        mock_response.status = 201
-        mock_urlopen.return_value = mock_response
-
-        report = {
+
+    def _sample_report(self):
+        return {
             "trust_score": 75,
             "tier_met": True,
             "cert_id": "BCOS-test123",
@@ -172,17 +172,64 @@ def test_post_comment_success(self, mock_urlopen):
                 "review_attestation": 10
             }
         }
+
+    @patch('main.urlopen')
+    def test_post_comment_success(self, mock_urlopen):
+        """Test successful comment posting."""
+        mock_response = MagicMock()
+        mock_response.status = 201
+        mock_urlopen.return_value = mock_response
 
         result = post_github_comment(
             repo="test/repo",
             pr_number="42",
-            report=report,
+            report=self._sample_report(),
             token="fake-token"
         )
 
         self.assertTrue(result)
         mock_urlopen.assert_called_once()
 
+    @patch('main.urlopen')
+    def test_post_comment_links_to_in_repo_action_source(self, mock_urlopen):
+        """Generated comments should not link to the unpublished action repo."""
+        mock_response = MagicMock()
+        mock_response.status = 201
+        mock_urlopen.return_value = mock_response
+
+        post_github_comment(
+            repo="test/repo",
+            pr_number="42",
+            report=self._sample_report(),
+            token="fake-token"
+        )
+
+        request = mock_urlopen.call_args.args[0]
+        body = json.loads(request.data.decode("utf-8"))["body"]
+        self.assertIn(BCOS_ACTION_URL, body)
+        self.assertNotIn(DEAD_BCOS_ACTION_URL, body)
+
+    @patch('post_comment.urlopen')
+    def test_standalone_post_comment_links_to_in_repo_action_source(self, mock_urlopen):
+        """The standalone comment script should use the same live action link."""
+        mock_response = MagicMock()
+        mock_response.status = 201
+        mock_urlopen.return_value = mock_response
+        report_json = json.dumps(self._sample_report()).encode("utf-8")
+
+        with patch.dict(os.environ, {
+            "GITHUB_TOKEN": "fake-token",
+            "REPO": "test/repo",
+            "PR_NUMBER": "42",
+            "REPORT_JSON": base64.b64encode(report_json).decode("ascii"),
+        }):
+            post_comment_script.main()
+
+        request = mock_urlopen.call_args.args[0]
+        body = json.loads(request.data.decode("utf-8"))["body"]
+        self.assertIn(BCOS_ACTION_URL, body)
+        self.assertNotIn(DEAD_BCOS_ACTION_URL, body)
+
 
 class TestRustChainAnchoring(unittest.TestCase):
     """Test RustChain anchoring."""

.github/actions/rtc-auto-bounty/action.yml

@@ -19,6 +19,10 @@ inputs:
     description: 'RustChain VPS host (IP or hostname)'
     required: false
     default: ''
+  rtc-api-url:
+    description: 'Full RustChain transfer API URL, for example https://rustchain.org/wallet/transfer'
+    required: false
+    default: ''
   rtc-admin-key:
     description: 'Admin key for the /wallet/transfer endpoint'
     required: false
@@ -76,6 +80,7 @@ runs:
       shell: bash
       env:
         INPUT_RTC_AMOUNT: ${{ inputs.rtc-amount }}
+        INPUT_RTC_API_URL: ${{ inputs.rtc-api-url }}
         INPUT_RTC_VPS_HOST: ${{ inputs.rtc-vps-host }}
         INPUT_RTC_ADMIN_KEY: ${{ inputs.rtc-admin-key }}
         INPUT_FROM_WALLET: ${{ inputs.from-wallet }}