Replace deprecated hnsw_rs save/load methods with file_dump/file_load#5
Merged
BryanChasko merged 1 commit intomainfrom Jul 20, 2025
Merged
Replace deprecated hnsw_rs save/load methods with file_dump/file_load#5BryanChasko merged 1 commit intomainfrom
BryanChasko merged 1 commit intomainfrom
Conversation
Copilot
AI
changed the title
[WIP] Rust ingest: replace deprecated {save/load} with {file_dump/file_load}
Replace deprecated hnsw_rs save/load methods with file_dump/file_load
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Rust ingest system to use the modern hnsw_rs API by replacing deprecated methods with their current equivalents.
Changes Made
Fixed Import Issues
hnsw_rs::dist::DistCosineimport (module doesn't exist in current version)hnsw_rs::prelude::*which properly includesDistCosinefromanndistsReplaced Deprecated Methods
index.dump(&index_path)withindex.file_dump(output_dir, "index")Hnsw::file_load(&data_dir, "index")with properHnswIo::new(&data_dir, "index").load_hnsw()Fixed Type System Issues
Hnsw<'_, f32, DistCosine>type annotationsHnswIolifetime requirementsBefore
After
The code now compiles successfully and uses the current hnsw_rs API as intended.
Fixes #3.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.