Skip to content

Bump starlette from 0.48.0 to 0.49.1 #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahouseholder merged 4 commits into from
Mar 11, 2026
Merged

Bump starlette from 0.48.0 to 0.49.1 #1076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d31607e
Bump starlette from 0.48.0 to 0.49.1
dependabot[bot] Mar 6, 2026
bf61100
Initial plan
Copilot Mar 11, 2026
3138118
Fix test failures caused by starlette 0.49.1 upgrade
Copilot Mar 11, 2026
dab6262
Fix test failures from starlette 0.49.1 upgrade (#1083)
ahouseholder Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/test/api/routers/test_decision_point.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import json
import unittest

from fastapi import HTTPException
from fastapi import FastAPI
from fastapi.testclient import TestClient

from ssvc.api.v1.routers import decision_point
Expand All @@ -29,7 +29,9 @@

class TestDecisionPointAPI(unittest.TestCase):
def setUp(self):
self.client = TestClient(decision_point.router)
app = FastAPI()
app.include_router(decision_point.router)
self.client = TestClient(app)

# create a new registry for testing
self.r = SsvcObjectRegistry(
Expand Down Expand Up @@ -86,8 +88,8 @@ def test_get_decision_point_by_id_success(self):
self.assertEqual(expected, response.json())

def test_get_decision_point_by_id_bad_id(self):
with self.assertRaises(HTTPException):
self.client.get("/decision_point?id=bad_id_format")
response = self.client.get("/decision_point?id=bad_id_format")
self.assertEqual(400, response.status_code)


if __name__ == "__main__":
Expand Down
10 changes: 6 additions & 4 deletions src/test/api/routers/test_decision_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import json
import unittest

from fastapi import HTTPException
from fastapi import FastAPI
from fastapi.testclient import TestClient

from ssvc.api.v1.routers import decision_table
Expand All @@ -30,7 +30,9 @@

class TestDecisionPointAPI(unittest.TestCase):
def setUp(self):
self.client = TestClient(decision_table.router)
app = FastAPI()
app.include_router(decision_table.router)
self.client = TestClient(app)

# create a new registry for testing
self.r = SsvcObjectRegistry(
Expand Down Expand Up @@ -110,8 +112,8 @@ def test_get_decision_point_by_id_success(self):
self.assertEqual(expected, response.json())

def test_get_decision_point_by_id_bad_id(self):
with self.assertRaises(HTTPException):
self.client.get("/decision_table?id=bad_id_format")
response = self.client.get("/decision_table?id=bad_id_format")
self.assertEqual(400, response.status_code)


if __name__ == "__main__":
Expand Down
Loading
Loading