PLT 1520 : Set bucket access logging defaults via modules #376
Closed
PLT 1520 : Set bucket access logging defaults via modules #376
Conversation
mianava
changed the title
Contributor
Author
|
Closing this ticket in favor of leveraging cloudtrail to track these. |
Contributor
Author
|
Closing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/PLT-1520
🛠 Changes
Every bucket created with the bucket module will have the pre configured bucket for access log storage and management assigned. Every instantiation of the platform module will have this bucket name available for downstream use in existing modules that are not currently leveraging the bucket module.
ℹ️ Context
These changes are made to ensure predictable use of the bucket access logging bucket, which is preconfigured to connect to other logging platforms.
🧪 Validation
Buckets using bucket module downstream will be automatically updated.
Details
``` # module.persistent.module.bucket.aws_s3_bucket_logging.this will be updated in-place ~ resource "aws_s3_bucket_logging" "this" { id = "dpc-dev-###" ~ target_bucket = "bucket-access-logs-###" -> "cms-cloud-###-us-east-1-access-logs" # (2 unchanged attributes hidden) } ```