Skip to content

fix: order session rooms#237

Open
Link1515 wants to merge 1 commit into
mainfrom
session-room-order
Open

fix: order session rooms#237
Link1515 wants to merge 1 commit into
mainfrom
session-room-order

Conversation

@Link1515

@Link1515 Link1515 commented Jun 30, 2026

Copy link
Copy Markdown
Member

Fix #232

Summary by CodeRabbit

  • New Features

    • Room lists are now shown in a more intuitive priority order, with key rooms appearing first.
  • Bug Fixes

    • Improved room sorting so entries no longer rely on simple alphabetical order.
    • Duplicate rooms are still removed as before, while the display order is now more consistent.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c3734c55-9b77-4035-8616-38e6120ce316

📥 Commits

Reviewing files that changed from the base of the PR and between 20ac317 and ddae5ea.

📒 Files selected for processing (1)
  • app/components/feature/CpSessionTable.vue

📝 Walkthrough

Walkthrough

Adds two helper functions (roomSortRank, compareRooms) to CpSessionTable.vue that implement a priority-based room ordering (RB105 first, then RB*, AU*, TR*, then others with localeCompare fallback), and applies this comparator to the rooms computed property's .sort() call.

Room Sort Ordering

Layer / File(s) Summary
Room sort helpers and computed update
app/components/feature/CpSessionTable.vue
roomSortRank maps room codes to numeric priorities (RB105=0, other RB*=1, AU*=2, TR*=3, else=4); compareRooms compares by rank with localeCompare fallback; rooms computed .sort() updated to use compareRooms.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hippity hop, the rooms line up right,
RB105 leads, stepping into the light,
Then RB, AU, TR follow along,
A sorted parade, a most orderly song,
No more mixed-up halls — everything's bright! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately describes the main change: session room ordering.
Linked Issues check ✅ Passed The room sort now follows RB → AU → TR, with the opening room forced to the top, matching #232.
Out of Scope Changes check ✅ Passed The change is limited to room ordering in CpSessionTable.vue and introduces no unrelated edits.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch session-room-order

Comment @coderabbitai help to get the list of available commands.

@mirumodapon mirumodapon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

議程聽的排序

2 participants