Skip to content

fix: place title and button on separate rows in session modal#283

Merged
mirumodapon merged 1 commit into
mainfrom
session-modal
Jul 15, 2026
Merged

fix: place title and button on separate rows in session modal#283
mirumodapon merged 1 commit into
mainfrom
session-modal

Conversation

@Link1515

@Link1515 Link1515 commented Jul 15, 2026

Copy link
Copy Markdown
Member

Fix #282

Summary

調整議程詳情 modal 的標題與操作按鈕版面,讓兩者分列顯示,避免長標題與按鈕互相擠壓。

Changes

  • 將分享、收藏與關閉按鈕移至標題上方的獨立列。
  • 移除議程標題為操作按鈕預留的右側邊距。
電腦版 手機板
1784080874870 1784080871840

Summary by CodeRabbit

  • Style
    • Improved the session detail modal layout for share, favorite, and close controls.
    • Adjusted session information card spacing for a more consistent header appearance.
    • Simplified title styling and removed unnecessary spacing behavior.

@rileychh-dokploy-coscup

rileychh-dokploy-coscup Bot commented Jul 15, 2026

Copy link
Copy Markdown

Dokploy Preview Deployment

Name Status Preview Updated (UTC)
Nuxt ✅ Done Preview URL 2026-07-15T02:06:21.886Z

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8207838e-5881-4997-bb1f-a4166869486b

📥 Commits

Reviewing files that changed from the base of the PR and between 9f2f642 and aa43020.

📒 Files selected for processing (2)
  • app/components/feature/CpSessionDetailModal.vue
  • app/components/feature/CpSessionInfoCard.vue

📝 Walkthrough

Walkthrough

The session detail UI updates header spacing, removes the unused title-margin prop, and simplifies the modal action-control layout with right-aligned flex styling.

Changes

Session detail layout

Layer / File(s) Summary
Remove title margin prop and adjust header spacing
app/components/feature/CpSessionInfoCard.vue
CpSessionInfoCard removes hasTitleMarginRight, changes article padding from py-5 to py-4, and removes the conditional heading margin class.
Align modal controls and update card usage
app/components/feature/CpSessionDetailModal.vue
The action-button container uses simplified right-aligned flex spacing, and the modal no longer passes the removed title-margin attribute.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • COSCUP/2026#215: Reuses CpSessionInfoCard and is directly affected by its prop change.
  • COSCUP/2026#222: Also changes CpSessionInfoCard header layout and styling.
  • COSCUP/2026#281: Touches the same session-detail modal and info-card components.

Suggested reviewers: pan93412, rileychh

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main session modal layout fix and is specific and concise.
Linked Issues check ✅ Passed The changes move the action buttons off the title row and remove the reserved spacing, matching issue #282.
Out of Scope Changes check ✅ Passed The only edits are the modal layout tweak and related card prop cleanup, with no unrelated changes evident.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch session-modal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pan93412
pan93412 requested a review from mirumodapon July 15, 2026 05:50
@mirumodapon
mirumodapon merged commit 7ad4f05 into main Jul 15, 2026
2 checks passed
@mirumodapon
mirumodapon deleted the session-modal branch July 15, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

分享與收藏功能會擠到標題

3 participants