Skip to content

refactor: rename CLI struct to ConsoleUI without changing behavior#216

Merged
vnepogodin merged 1 commit into
CachyOS:developfrom
ptcodes:refactor/rename-cli-struct
Apr 15, 2026
Merged

refactor: rename CLI struct to ConsoleUI without changing behavior#216
vnepogodin merged 1 commit into
CachyOS:developfrom
ptcodes:refactor/rename-cli-struct

Conversation

@ptcodes
Copy link
Copy Markdown
Contributor

@ptcodes ptcodes commented Apr 5, 2026

Initially, I just wanted to address the following warning below by clippy and to change the CLI struct to Cli but we already had the Cli struct in cli.rs added by clap. That's pretty confusing.

I've renamed CLI to ConsoleUi and added a test. No changing behavior was introduced.

@vnepogodin please review.

error: name `CLI` contains a capitalized acronym
 --> src/cli.rs:6:12
  |
6 | pub struct CLI;
  |            ^^^ help: consider making the acronym lowercase, except the initial letter: `Cli`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
  = note: `-D clippy::upper-case-acronyms` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::upper_case_acronyms)]`

Copy link
Copy Markdown
Member

@vnepogodin vnepogodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need rebase

@ptcodes ptcodes force-pushed the refactor/rename-cli-struct branch from 38da97d to 9a8f2b0 Compare April 13, 2026 01:52
@ptcodes
Copy link
Copy Markdown
Contributor Author

ptcodes commented Apr 13, 2026

@vnepogodin rebased onto the latest develop

@ptcodes ptcodes requested a review from vnepogodin April 13, 2026 01:58
@vnepogodin vnepogodin merged commit 112d9fb into CachyOS:develop Apr 15, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants