Skip to content

Feature/remove vancouver 130#148

Merged
ahmad1368 merged 7 commits into
stagingfrom
feature/remove-vancouver-130
Jun 23, 2026
Merged

Feature/remove vancouver 130#148
ahmad1368 merged 7 commits into
stagingfrom
feature/remove-vancouver-130

Conversation

@ahmad1368

@ahmad1368 ahmad1368 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Closes #130

  • Removed "Select Your City" modal on page load.
  • Removed "select location" button from the top right navigation header.
  • Set the default home page rendering configuration to Toronto.
    @vincent6767 Check, Please!!!

@vincent6767
vincent6767 self-requested a review June 18, 2026 23:40
@vincent6767

vincent6767 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@ahmad1368
What are your thoughts on writing unit tests these changes? Maybe we test the behaviour, e.g. no momentary Vancouver states if we call setCity("vancouver", updateUrl=true).

@vincent6767

vincent6767 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@ahmad1368 Please merge this when you're available.

@ahmad1368

ahmad1368 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@ahmad1368 What are your thoughts on writing unit tests these changes? Maybe we test the behaviour, e.g. no momentary Vancouver states if we call setCity("vancouver", updateUrl=true).

It should be good but let other teammate do it, I'm going to solve other issues

@ahmad1368
ahmad1368 merged commit e82b16a into staging Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vincent6767 vincent6767 vincent6767 approved these changes

Assignees

@ahmad1368 ahmad1368

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahmad1368 @vincent6767