Skip to content

feat: setup Vancouver 2026 archive structure and content definitions #131#149

Merged
ahmad1368 merged 4 commits into
stagingfrom
feature/archive-vancouver-131
Jun 22, 2026
Merged

feat: setup Vancouver 2026 archive structure and content definitions #131#149
ahmad1368 merged 4 commits into
stagingfrom
feature/archive-vancouver-131

Conversation

@ahmad1368

Copy link
Copy Markdown
Contributor

Description

  • Initialized the structure and static assets for the Vancouver 2026 archive page.
  • Updated content definitions in src/lib/content.ts to support the archive feature.
  • Added necessary declaration files and updated package locks.

Related Branch

feature/archive-vancouver-131

How to Test

  1. Run npm run dev or build the project locally.
  2. Verify that the new archive structure and route configurations for Vancouver do not introduce any build errors.
    @vincent6767 Check please

@vincent6767 vincent6767 linked an issue Jun 19, 2026 that may be closed by this pull request
@vincent6767

Copy link
Copy Markdown
Contributor

HI @ahmad1368 ,
I have verified there are no build errors. Where is the unit test? I can't find it in the PR.

@vincent6767 vincent6767 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments on the PR.

Comment thread src/lib/content.ts
},
};
}

// For backwards compatibility
export const heroContent: Record<City, HeroContent> = {
vancouver: getHeroContent('vancouver'),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ahmad1368 , do we still need this in the archive page? It's an archive for Vancouver pages

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vincent6767,

Since I joined the project mid-development, the codebase was already structured this way. Given our tight deadline and the need to deliver updates quickly, I focused on making minimal changes to the existing architecture to avoid regression.

Since this is purely a static archive page that won't require frequent updates or future maintenance, hardcoding certain parts was the most efficient approach to meet our target date.

We can definitely revisit this for a proper refactor and cleanup later if Matt or BB prioritizes it. Let me know if you'd prefer any immediate adjustments!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay for this one. Thanks for checking.

Comment thread src/lib/content.ts Outdated
},
],
// pressReleases: [
// { text: '2025 Press Release', href: '/archive/2025/index.html' },
// ],
previousYears: [
{ text: '2025', href: '/archive/2025/index.html' },
{ text: '2024', href: '/archive/2024.html' },
{ text: "2026", href: "/archive/2026/index.html" },

@vincent6767 vincent6767 Jun 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to #131 Acceptance Criteria 1, the wording should be "Vancouver - 2026". @ahmad1368 Can you update this?

@vincent6767 vincent6767 Jun 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmad1368 Please add an instruction to run the test in the readme.md. I'll create a new issue where we run the unit test every time we create a PR. This is the issue link: #153

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to #131 Acceptance Criteria 1, the wording should be "Vancouver - 2026". @ahmad1368 Can you update this?

Did it!!!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmad1368 Please add an instruction to run the test in the readme.md. I'll create a new issue where we run the unit test every time we create a PR. This is the issue link: #153

I'll follow it

@ahmad1368

ahmad1368 commented Jun 19, 2026 via email

Copy link
Copy Markdown
Contributor Author

@ahmad1368

ahmad1368 commented Jun 19, 2026 via email

Copy link
Copy Markdown
Contributor Author

@vincent6767

Copy link
Copy Markdown
Contributor

@ahmad1368
Thanks for clarifying the dependencies. You're right. #131 should be completed before the rest of the issues are completed. The only action item is the unit test then.

@ahmad1368

Copy link
Copy Markdown
Contributor Author

I have updated the archive link text format to "Vancouver - 2026" and added the integration unit tests to the tests/ folder as requested.

@vincent6767

Copy link
Copy Markdown
Contributor

@ahmad1368 Approved. Let's merge it so you can work on the remaining tasks.

@ahmad1368

Copy link
Copy Markdown
Contributor Author

Hi @vincent6767,

Based on the footer UI screenshot, I also think it makes a lot of sense to change the header from "Previous Years" to "Previous Events".

Since the Toronto event is scheduled to take place later in 2026, keeping the header as "Previous Years" creates a logical conflict when listing "Vancouver - 2026" under it. Changing it to "Previous Events" naturally resolves this and fits perfectly with the multi-city expansion.

If you agree, I can quickly update that header text as well!

@ahmad1368
ahmad1368 merged commit ae5d04c into staging Jun 22, 2026
@vincent6767

vincent6767 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Hi @vincent6767,

Based on the footer UI screenshot, I also think it makes a lot of sense to change the header from "Previous Years" to "Previous Events".

Since the Toronto event is scheduled to take place later in 2026, keeping the header as "Previous Years" creates a logical conflict when listing "Vancouver - 2026" under it. Changing it to "Previous Events" naturally resolves this and fits perfectly with the multi-city expansion.

If you agree, I can quickly update that header text as well!

Great suggestions. Let's do that. Thank you! @ahmad1368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Archive Vancouver page with link in footer

2 participants