feat: setup Vancouver 2026 archive structure and content definitions #131#149
Conversation
|
HI @ahmad1368 , |
vincent6767
left a comment
There was a problem hiding this comment.
I have left some comments on the PR.
| }, | ||
| }; | ||
| } | ||
|
|
||
| // For backwards compatibility | ||
| export const heroContent: Record<City, HeroContent> = { | ||
| vancouver: getHeroContent('vancouver'), |
There was a problem hiding this comment.
Hi @ahmad1368 , do we still need this in the archive page? It's an archive for Vancouver pages
There was a problem hiding this comment.
Hi @vincent6767,
Since I joined the project mid-development, the codebase was already structured this way. Given our tight deadline and the need to deliver updates quickly, I focused on making minimal changes to the existing architecture to avoid regression.
Since this is purely a static archive page that won't require frequent updates or future maintenance, hardcoding certain parts was the most efficient approach to meet our target date.
We can definitely revisit this for a proper refactor and cleanup later if Matt or BB prioritizes it. Let me know if you'd prefer any immediate adjustments!
There was a problem hiding this comment.
It's okay for this one. Thanks for checking.
| }, | ||
| ], | ||
| // pressReleases: [ | ||
| // { text: '2025 Press Release', href: '/archive/2025/index.html' }, | ||
| // ], | ||
| previousYears: [ | ||
| { text: '2025', href: '/archive/2025/index.html' }, | ||
| { text: '2024', href: '/archive/2024.html' }, | ||
| { text: "2026", href: "/archive/2026/index.html" }, |
There was a problem hiding this comment.
According to #131 Acceptance Criteria 1, the wording should be "Vancouver - 2026". @ahmad1368 Can you update this?
There was a problem hiding this comment.
@ahmad1368 Please add an instruction to run the test in the readme.md. I'll create a new issue where we run the unit test every time we create a PR. This is the issue link: #153
There was a problem hiding this comment.
According to #131 Acceptance Criteria 1, the wording should be "Vancouver - 2026". @ahmad1368 Can you update this?
Did it!!!
There was a problem hiding this comment.
@ahmad1368 Please add an instruction to run the test in the readme.md. I'll create a new issue where we run the unit test every time we create a PR. This is the issue link: #153
I'll follow it
|
Hi Vincent,
1. Regarding the text update: I will absolutely change the wording to "Vancouver - 2026" as requested in #131 AC3 in my next commit.
2. Regarding the `vancouver: getHeroContent('vancouver')` and the archive page:
There was a slight dependency conflict in the order of the issues. Issue #130 asked to completely remove Vancouver from the home page, but the subsequent issue requires backing up/archiving the Vancouver pages. When implementing #133, the Vancouver references had to be removed first, which technically means there was no Vancouver content left to archive at that specific stage.
However, I have already managed and anticipated this cross-issue logic across both #133 and the upcoming issue. Once you merge these changes, you will see that the Vancouver archive is properly implemented and handled in the next issue's PR.
I'll push the text fix shortly!
________________________________
From: Vincent ***@***.***>
Sent: Friday, June 19, 2026 11:11 AM
To: CanadianCloud/cloudsummit.github.io ***@***.***>
Cc: ahmad1368 ***@***.***>; Assign ***@***.***>
Subject: Re: [CanadianCloud/cloudsummit.github.io] feat: setup Vancouver 2026 archive structure and content definitions #131 (PR #149)
@vincent6767 commented on this pull request.
I have left some comments on the PR.
________________________________
In src/lib/content.ts<#149 (comment)>:
},
};
}
// For backwards compatibility
export const heroContent: Record<City, HeroContent> = {
- vancouver: getHeroContent('vancouver'),
Hi @ahmad1368<https://github.com/ahmad1368> , do we still need this in the archive page? It's an archive for Vancouver pages
________________________________
In src/lib/content.ts<#149 (comment)>:
},
],
// pressReleases: [
// { text: '2025 Press Release', href: '/archive/2025/index.html' },
// ],
previousYears: [
- { text: '2025', href: '/archive/2025/index.html' },
- { text: '2024', href: '/archive/2024.html' },
+ { text: "2026", href: "/archive/2026/index.html" },
According to #131<#131> Acceptance Criteria 3, the wording should be "Vancouver - 2026". @ahmad1368<https://github.com/ahmad1368> Can you update this?
—
Reply to this email directly, view it on GitHub<#149?email_source=notifications&email_token=AFJR7UL6IEL3QX3TYPARWGL5AV663A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINJTGQ3DENBSGUZKM4TFMFZW63VGMFZXG2LHN2SWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4534624252>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFJR7UJC4VY3HT7SVEMEGBL5AV663AVCNFSNUABGKJSXA33TNF2G64TZHMYTCMRVGQYTCOBUGI5US43TOVSTWNBWHE4DANJVGIYTRILWAI>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS<https://github.com/notifications/mobile/ios/AFJR7UJQMXB7ECUEVXSLZH35AV663A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINJTGQ3DENBSGUZKM4TFMFZW63VGMFZXG2LHN2SWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android<https://github.com/notifications/mobile/android/AFJR7UKSV5GBM5OMDXIOLDL5AV663A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINJTGQ3DENBSGUZKM4TFMFZW63VGMFZXG2LHN2SWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today!
You are receiving this because you were assigned.Message ID: ***@***.***>
|
|
Hi Vincent,
My apologies, I missed including the unit test file in this specific commit. I am adding the test right now and will push it to this PR shortly.
Thanks for catching that!
…________________________________
From: Vincent ***@***.***>
Sent: Friday, June 19, 2026 11:11 AM
To: CanadianCloud/cloudsummit.github.io ***@***.***>
Cc: ahmad1368 ***@***.***>; Mention ***@***.***>
Subject: Re: [CanadianCloud/cloudsummit.github.io] feat: setup Vancouver 2026 archive structure and content definitions #131 (PR #149)
[https://avatars.githubusercontent.com/u/15702735?s=20&v=4]vincent6767 left a comment (CanadianCloud/cloudsummit.github.io#149)<#149 (comment)>
HI @ahmad1368<https://github.com/ahmad1368> ,
I have verified there are no build errors. Where is the unit test? I can't find it in the PR.
—
Reply to this email directly, view it on GitHub<#149?email_source=notifications&email_token=AFJR7UNGIRS2EJMNJGHIEWT5AV643A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZVGM4DCNJRHAZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4753815183>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFJR7UPN4NOGPQHIIMSENZ35AV643AVCNFSNUABGKJSXA33TNF2G64TZHMYTCMRVGQYTCOBUGI5US43TOVSTWNBWHE4DANJVGIYTRILWAI>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS<https://github.com/notifications/mobile/ios/AFJR7UOVQV4LL4MQGHFHHHL5AV643A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZVGM4DCNJRHAZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> and Android<https://github.com/notifications/mobile/android/AFJR7UPC45OERAPHYVTLC7T5AV643A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZVGM4DCNJRHAZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. Download it today!
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@ahmad1368 |
|
I have updated the archive link text format to "Vancouver - 2026" and added the integration unit tests to the |
|
@ahmad1368 Approved. Let's merge it so you can work on the remaining tasks. |
|
Hi @vincent6767, Based on the footer UI screenshot, I also think it makes a lot of sense to change the header from "Previous Years" to "Previous Events". Since the Toronto event is scheduled to take place later in 2026, keeping the header as "Previous Years" creates a logical conflict when listing "Vancouver - 2026" under it. Changing it to "Previous Events" naturally resolves this and fits perfectly with the multi-city expansion. If you agree, I can quickly update that header text as well! |
Great suggestions. Let's do that. Thank you! @ahmad1368 |
Description
src/lib/content.tsto support the archive feature.Related Branch
feature/archive-vancouver-131How to Test
npm run devor build the project locally.@vincent6767 Check please