Implemented cards from the PUNK set - #11510
Conversation
Added/updated entries to the following counters: - Dread (Positive > Neutral) [Balances the negative effect of No Way Out] - Glass (Negative) - Shy (Neutral) [Neutral since the Coward effect of Shy Town isn't tied to the counter] - Point (Positive)
- Made additions/edits to AmassEffect.java and AmassAi.java to make it able to handle non-black army tokens (any valid combination of colors will work). [Implemented with assistance from Claude]
It's my first time doing a Java code-related change, so criticism is very much appreciated. Performed with assistance from Claude. |
|
Implementing a "color" parameter for Amass is a bit of a grey area, since the keyword on the card isn't using that color as a parameter the way it does with the creature type - e.g.. it doesn't "Amass Red Fans 5". The reminder text seems to indicate that Fans are just an exception to the existing Amass behavior. So at its most literal, it'd be done by checking if the type is "Fans" in the Amass effect and if so, making a red army instead. But that isn't particularly flexible. Your way is flexible, but introducing a keyword parameter might be a bit much for a single, non-legal, non-Oracle, non-traditional card that also doesn't use a keyword parameter, and is from a set that often sees functional errata with reprints. I'd suggest holding off on adding color-Amass to the engine until Wizards gives us a few more examples. |
- Dread Counter in CounterEnumType - Neutral > Positive - Removed The Sphere implementation for now.
|
That's bad timing. Just noticed a bit of inconsistency. |
|
Failing to compile because Point counters already exist as a counter type it seems. Have you tested these? |
I have done some testing with the cards. I just missed the entry on the point counter on the enums. That's my bad. |
Implented the following cards that didn't require code changes from the Black Lotus Unknown Planechase set:
Implemented with assistance from Claude.