Skip to content

Implemented cards from the PUNK set - #11510

Open
BigCrunch22 wants to merge 21 commits into
Card-Forge:masterfrom
BigCrunch22:add-card
Open

Implemented cards from the PUNK set#11510
BigCrunch22 wants to merge 21 commits into
Card-Forge:masterfrom
BigCrunch22:add-card

Conversation

@BigCrunch22

@BigCrunch22 BigCrunch22 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Implented the following cards that didn't require code changes from the Black Lotus Unknown Planechase set:

  • Asmoranomardicadaistinaculdacar's Kitchen
  • Bicycle Rack
  • Black Lotus Lounge
  • Circus of the Sun + Token
  • City Hall
  • Elvish Impersonation Contest
  • Event Horizon
  • Ghirapur Grand Prix
  • Jalira's Show + Token
  • Mojave Desert
  • No Way Out
  • Omenpath Instability + Tokens
  • Oteclán
  • Preston's Stage + Token
  • Probability Flux
  • Pursued by Something
  • Raiders' Allegiance
  • Shy Town
  • Sky Deck
  • Tarnation
  • That's Enough Slices + Token
  • The Bean
  • The Food Court
  • The Windy City

Implemented with assistance from Claude.

Comment thread forge-gui/res/cardsfolder/w/welcome_to_valley.txt Outdated
@Jetz72
Jetz72 requested a review from dracontes August 4, 2026 15:05
@Jetz72 Jetz72 added the Un-Cards Support or implementations for silver-border, playtest, or otherwise non-legal cards. label Aug 4, 2026
BigCrunch22 and others added 4 commits August 5, 2026 17:31
Added/updated entries to the following counters:

- Dread (Positive > Neutral) [Balances the negative effect of No Way Out]
- Glass (Negative)
- Shy (Neutral) [Neutral since the Coward effect of Shy Town isn't tied to the counter]
- Point (Positive)
- Made additions/edits to AmassEffect.java and AmassAi.java to make it able to handle non-black army tokens (any valid combination of colors will work). [Implemented with assistance from Claude]
@BigCrunch22

BigCrunch22 commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author
  • Added The Sphere, which required code changes (AmassAi and AmassEffect)

It's my first time doing a Java code-related change, so criticism is very much appreciated. Performed with assistance from Claude.

Comment thread forge-game/src/main/java/forge/game/card/CounterEnumType.java Outdated
@Jetz72

Jetz72 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Implementing a "color" parameter for Amass is a bit of a grey area, since the keyword on the card isn't using that color as a parameter the way it does with the creature type - e.g.. it doesn't "Amass Red Fans 5". The reminder text seems to indicate that Fans are just an exception to the existing Amass behavior.

So at its most literal, it'd be done by checking if the type is "Fans" in the Amass effect and if so, making a red army instead. But that isn't particularly flexible. Your way is flexible, but introducing a keyword parameter might be a bit much for a single, non-legal, non-Oracle, non-traditional card that also doesn't use a keyword parameter, and is from a set that often sees functional errata with reprints. I'd suggest holding off on adding color-Amass to the engine until Wizards gives us a few more examples.

Jetz72
Jetz72 previously approved these changes Aug 12, 2026
@BigCrunch22

Copy link
Copy Markdown
Contributor Author

That's bad timing. Just noticed a bit of inconsistency.

@BigCrunch22
BigCrunch22 requested a review from Jetz72 August 12, 2026 14:40
@Jetz72

Jetz72 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Failing to compile because Point counters already exist as a counter type it seems. Have you tested these?

@BigCrunch22

Copy link
Copy Markdown
Contributor Author

Failing to compile because Point counters already exist as a counter type it seems. Have you tested these?

I have done some testing with the cards. I just missed the entry on the point counter on the enums. That's my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Un-Cards Support or implementations for silver-border, playtest, or otherwise non-legal cards.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants