Confirm edit-state cleanup bug already fixed; no code changes#315
Closed
Copilot wants to merge 1 commit into
Closed
Confirm edit-state cleanup bug already fixed; no code changes#315Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Copilot
AI
changed the title
[WIP] Fix stale local state during edit transitions
Confirm edit-state cleanup bug already fixed; no code changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue reports that three non-
EditButtonspaths into editing (ValueNodeWrappersetIsEditing,CollectionNodesetIsEditing,CollectionNodeEditButtonsclick) calledstartEdit(path)without acancelOp, leaving stale local state (value/stringifiedValue/previousValue) on the previous node when the edit transitioned.Verification
All three call sites now register a
cancelOp— no further changes required:src/ValueNodeWrapper.tsx:420—setIsEditing: canEdit ? () => startEdit(path, { cancelOp: revertSession }) : NOOP.revertSession(line 370) applies and clears thepreviousValuesnapshot.src/CollectionNode.tsx:523— custom-nodesetIsEditing: () => startEdit(path, { cancelOp: clearEditBuffer }).src/CollectionNode.tsx:546—EditButtonsclick handler now also passes{ cancelOp: clearEditBuffer }.clearEditBuffer(line 173) resetsstringifiedValue.Inline comments at both
revertSessionandclearEditBufferexplicitly document the "edit moves to another node" path the issue describes, matching the proposed fix in intent and shape.Out of scope
KeyDisplay.tsx:126still callsstartEdit(path)without acancelOp, but that's on the key-edit path — not one of the three sites enumerated in the issue.Optional follow-up
The issue suggests a behavioural regression test ("transitioning edits via double-click resets the previous node's local state"). Not added here since no code change is being made; happy to add one if desired.