-
Notifications
You must be signed in to change notification settings - Fork 18
Fix/update fix nu6 #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix/update fix nu6 #153
Conversation
irubido
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me,
but still wallet does not work when built in WASM.
got this error in browser console
webzjs_wallet.js:1621 panicked at /home/ivan/.cargo/git/checkouts/librustzcash-c2c6180a1a11d4fa/a40ee35/zcash_client_memory/src/wallet_read.rs:734:9:
not yet implemented
|
@sqhell has the WASM panic issue been resolved?
➕ |
rob1997
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix the WASM panic by ensuring the librustzcash fork has the required implementation
- Test WASM build in browser environment
- Verify
get_wallet_summary()works after wallet creation - Update README.md to reflect new constructor signature (currently shows old API), line 37 to show new constructor
|
@rob1997 I'm not a maintainer of this repository, so I can't really give this change an insightful review. |
|
Great job with fix, just some of functionality still throws errors Managed to sync to block 2978667 quite fast 👍 , transaction worked both to On page refresh i got errors and toast message passed to webapp
|
Changes
Details
The breaking change was the Zcash NU6 (Network Upgrade 6) update in the official librustzcash.
Specifically:
Quick Checklist for Infra Team
Test Before Deploying
They can verify headers are working by checking browser console:
// Should return true if headers are set correctly
console.log(typeof SharedArrayBuffer !== 'undefined')
Tests
Run unit tests for ConfirmationsPolicy validation
cargo test --package webzjs-wallet --lib validation
Run e2e tests (requires yarn and playwright)
cd packages/e2e-tests
yarn install
npx playwright test --project=chromium
Issues