hp_proliant_da_cntlr: skip phantom controllers, make 'other' state configurable#928
Closed
Bastian-Kuhn wants to merge 1 commit into
Closed
Conversation
…nfigurable
On HPE ProLiant Gen11 / iLO 6 the controller table (cpqDaCntlrTable) contains
a phantom placeholder row -- typically index 0 -- whose condition, role, board
status and board condition cells are all '0' (a value the vendor MIB does not
define). parse_hp_proliant_da_cntlr already parsed such rows to None, but the
discovery function iterated over all section keys and still discovered the
phantom item, whose service was then permanently UNKNOWN ('Controller not found
in SNMP data'). Discovery now skips None entries.
In addition, Gen11 / iLO 6 firmware reports the board condition as 'other' for
healthy controllers, which maps to WARN and pins the service on WARN forever.
Add a check parameter ruleset 'HPE ProLiant RAID controller' that remaps the
state for the 'other' value of the controller condition, board condition and
board status independently. Defaults remain WARN, so behaviour is unchanged
until a rule is configured.
Update the unit test accordingly.
Bastian-Kuhn
force-pushed
the
fix-hp-proliant-da-cntlr-phantom-and-other-state
branch
from
9a49d05 to
255b71d
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two fixes for
hp_proliant_da_cntlr(HPE ProLiant RAID controllers), both triggered by ProLiant Gen11 / iLO 6:Skip phantom controllers. The controller table (
cpqDaCntlrTable) contains a placeholder row — typically index 0 — whose condition/role/board‑status/board‑condition cells are all0(a value the vendor MIB does not define).parse_hp_proliant_da_cntlralready parses such rows toNone, butdiscovery_hp_proliant_da_cntlriterated over all section keys and still discovered the phantom item, whose service was then permanentlyUNKNOWN("Controller not found in SNMP data"). Discovery now skipsNoneentries.Configurable
otherstate. Gen11 / iLO 6 firmware reports the board condition asotherfor perfectly healthy controllers, which maps toWARNand pins the service onWARNforever. A new check‑parameter ruleset "HPE ProLiant RAID controller" remaps the monitoring state for theothervalue of the controller condition, board condition and board status independently.Compatibility
Defaults stay
WARN, i.e. identical to today's behaviour until a rule is configured. Existing phantom services disappear on the next service discovery.Tests
tests/unit/.../test_hp_proliant_da_cntlr.pyupdated: phantom row no longer discovered, check functions takeparams, plus a new test for theother→OK remap.