Skip to content

chore(deps-dev): update eslint to v10#2393

Open
mturac wants to merge 2 commits into
ChromeDevTools:mainfrom
mturac:fix/issue-955
Open

chore(deps-dev): update eslint to v10#2393
mturac wants to merge 2 commits into
ChromeDevTools:mainfrom
mturac:fix/issue-955

Conversation

@mturac

@mturac mturac commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Fixes #955

Summary

  • update ESLint and @eslint/js to v10
  • replace the import lint plugin with an ESLint 10-compatible implementation while preserving the existing import and Node protocol checks
  • update the local license rule for ESLint 10's rule-context properties
  • align the supported Node.js versions with ESLint 10's engine requirements
  • preserve the current recommended-rule baseline during the major upgrade

Testing

  • npm ci
  • npm run check-format
  • npm run typecheck
  • npm run test

@Lightning00Blade

Copy link
Copy Markdown
Collaborator

Let's not change the deps for now, we can simply add the following code to the package.json:

  "overrides": {
    "eslint-plugin-import": {
      "eslint": "$eslint"
    }
  },

Which will force use EsLint v10 which is only incompatible because of eslint-plugin-import does not declare it an acceptable peer dependency, but code wise it works.

@Lightning00Blade
Lightning00Blade self-requested a review July 22, 2026 14:37
Comment thread package.json Outdated
},
"engines": {
"node": "^20.19.0 || ^22.12.0 || >=23"
"node": "^20.19.0 || ^22.13.0 || >=24"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change. The field say what our package supports, local development can require a different ones.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This showed up again.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored the top-level package engine range and lockfile mirror to ^20.19.0 || ^22.12.0 || >=23, while keeping the eslint-plugin-import override.

Validation:

  • npm run check-format
  • npm run build
  • npm run test -- --test-concurrency=1

@mturac

mturac commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Updated this to keep the existing eslint-plugin-import setup, add the ESLint peer override, and restore the package engine range.

Validation:

  • npm run check-format
  • npm run build
  • npm run test -- --test-concurrency=1

@OrKoN
OrKoN requested a review from Lightning00Blade July 22, 2026 19:16
@OrKoN

OrKoN commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the PR! @Lightning00Blade could you please re-gen package-lock locally for this fix?

@mturac
mturac force-pushed the fix/issue-955 branch 2 times, most recently from b712b99 to 38ab374 Compare July 22, 2026 20:23
@mturac

mturac commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Rebased on latest main and regenerated the lockfile locally with npm install --package-lock-only; it produced no tracked changes.

Validation:

  • npm run check-format
  • npm run build
  • npm run test -- --test-concurrency=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update eslint major version to v10

3 participants