Non-allocating Uint8Array access#684
Draft
AnsisMalins wants to merge 1 commit intoClearFoundry:masterfrom
Draft
Conversation
Collaborator
|
Hi @AnsisMalins, Some observations:
We do like this idea in general, as ClearScript already provides special treatment for typed arrays elsewhere. Typed arrays were designed for performance-critical scenarios. Can you tell us anything about yours? Thanks! |
Contributor
Author
|
Yes, I missed a file there. Oops! The specific case I'm trying to solve is, JavaScript code sends new byte arrays to C# side many times per frame, 60 frames per second. As is, for every JavaScript object a V8ObjectImpl is created on the C# side, and I'm trying to bring allocations per frame down to zero. I have limited control over the JavaScript side, so I can't ensure it reuses a small amount JavaScript objects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a new Uint8Array type that mirrors the V8's type. It is a
readonly ref struct. The use case is to retrieve it and pass it around inside the calling code for some small distance until its contents can be copied out to abyte[]array.By itself, this change does no avoid the allocation of a V8ObjectImpl as that still happens in V8FastArgs.ctor.