fix: valgrind-codspeed version comparison

[not-matthias]

No description provided.

[codspeed-hq]

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 7 untouched benchmarks

---

_{Comparing cod-2782-properly-compare-codspeed-valgrind-versions-for-the-same (f8f7496) with main (873caf0)}

[greptile-apps]

Greptile Summary

This PR fixes a version comparison bug where a stale CodSpeed-repackaged valgrind (same upstream semver but an older .codspeedN iteration) was incorrectly accepted as up-to-date. It introduces VALGRIND_CODSPEED_ITERATION as the single source of truth and plumbs it through the version string, the .deb rev suffix, and the installed-version check.

• VALGRIND_CODSPEED_ITERATION is added to binary_pins.rs; VALGRIND_DEB_REV and VALGRIND_CODSPEED_VERSION_STRING are derived from it rather than being hardcoded, so a future repackaging only requires editing one constant.
• parse_valgrind_codspeed_version now returns a ValgrindVersion { semver, codspeed_iteration } struct; classify_valgrind_version is extracted as a standalone, testable function that does a lexicographic tuple comparison (semver, iteration) against the pinned values — correctly rejecting older iterations at the same upstream semver.
• Nine new unit tests cover the exact failure modes: stale iteration, legacy suffix, pinned iteration, newer iteration, and newer semver with legacy suffix.

Confidence Score: 5/5

Safe to merge — the change is a targeted, well-tested fix to the version comparison path with no side-effects on install or download logic.

The iteration constant is derived consistently across all three places it appears (deb rev, version string, comparison), the tuple comparison is lexicographically correct for the intended ordering, and nine new tests exercise every relevant boundary.

No files require special attention.

Important Files Changed

Filename	Overview
src/binary_pins.rs	Extracts the repackaging iteration into VALGRIND_CODSPEED_ITERATION and derives both VALGRIND_DEB_REV and VALGRIND_CODSPEED_VERSION_STRING from it, so bumping the iteration is now a single-number edit.
src/executor/valgrind/setup.rs	Adds ValgrindVersion struct, refactors the parser to return semver + optional iteration, and fixes the comparison bug by using a tuple (semver, iteration) against the pinned constants. Extracts classify_valgrind_version for testability and adds comprehensive tests covering all cases.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["valgrind --version stdout"] --> B["trim to version string"]
    B --> C{contains .codspeed?}
    C -- No --> D["IncorrectVersion: not a CodSpeed build"]
    C -- Yes --> E["parse_valgrind_codspeed_version()"]
    E --> F["strip valgrind- prefix, split_once on .codspeed"]
    F -- parse fails --> G["IncorrectVersion: could not parse version"]
    F -- success --> H["ValgrindVersion with semver and codspeed_iteration"]
    H --> I["installed_iteration = codspeed_iteration.unwrap_or(0)"]
    I --> J{"semver, installed_iteration less than PINNED_VERSION, PINNED_ITERATION?"}
    J -- Yes --> K["IncorrectVersion: version too old"]
    J -- No --> L["Installed"]

Loading

_{Reviews (2): Last reviewed commit: "chore(valgrind): log detected valgrind v..." | Re-trigger Greptile}

[GuillaumeLagrange]

lgtm