feat: enable cycle estimation and allocation exclusion by default - #461
Merged
not-matthias merged 1 commit intoJul 27, 2026
Conversation
Greptile SummaryThis PR makes cycle estimation and allocation exclusion the normal default behavior. The main changes are:
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| src/cli/shared.rs | Adds default-on shared flags and environment variables for cycle estimation and allocation exclusion. |
| src/cli/experimental.rs | Keeps the old graduated experimental fields hidden and warns when active deprecated flags are used. |
| src/cli/run/mod.rs | Uses the new shared fields when building run orchestrator config and updates test defaults. |
| src/cli/exec/mod.rs | Uses the new shared fields when building exec orchestrator config. |
| src/executor/config.rs | Updates test orchestrator defaults to match the new default-on behavior. |
| src/upload/interfaces.rs | Updates the exclude_allocations serialization comment for the new opt-out behavior. |
Reviews (6): Last reviewed commit: "feat: enable cycle estimation and alloca..." | Re-trigger Greptile
Performance comparison unavailableA heads-up: this makes performance comparison unavailable when comparing benchmarks before and after this change:
Comparing |
not-matthias
marked this pull request as ready for review
July 21, 2026 18:27
GuillaumeLagrange
approved these changes
Jul 27, 2026
GuillaumeLagrange
left a comment
Contributor
There was a problem hiding this comment.
olgtm, make sure to not merge before we minor release
not-matthias
force-pushed
the
cod-2950-enable-cycle-estimationexclude-allocators-in-runner-for
branch
from
July 27, 2026 09:26
92f25c7 to
0f82e27
Compare
not-matthias
force-pushed
the
cod-2950-enable-cycle-estimationexclude-allocators-in-runner-for
branch
from
July 27, 2026 09:32
0f82e27 to
13499ef
Compare
not-matthias
force-pushed
the
cod-2950-enable-cycle-estimationexclude-allocators-in-runner-for
branch
2 times, most recently
from
July 27, 2026 10:02
a50fe11 to
d4b65cd
Compare
Graduate --cycle-estimation and --exclude-allocations out of the experimental flag set. They are now normal, default-on options that can be disabled with --cycle-estimation=false / --exclude-allocations=false (env: CODSPEED_CYCLE_ESTIMATION, CODSPEED_EXCLUDE_ALLOCATIONS). --experimental-fair-sched remains experimental.
not-matthias
force-pushed
the
cod-2950-enable-cycle-estimationexclude-allocators-in-runner-for
branch
from
July 27, 2026 17:21
d4b65cd to
aebdbbc
Compare
Member
Author
|
@greptileai review |
not-matthias
deleted the
cod-2950-enable-cycle-estimationexclude-allocators-in-runner-for
branch
July 27, 2026 17:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Graduate
--cycle-estimationand--exclude-allocationsout of the experimental flag set so both simulation behaviors are enabled for everyone by default.default_value_t = true.--cycle-estimation=false/--exclude-allocations=false(or envCODSPEED_CYCLE_ESTIMATION,CODSPEED_EXCLUDE_ALLOCATIONS) disable them.Experimentalhelp heading and no longer trigger the experimental-flags warning.--experimental-fair-schedis intentionally left untouched (still experimental, default off).Changes
src/cli/shared.rscycle_estimation/exclude_allocationstoggleable bools (default true,require_equals) toExecAndRunSharedArgssrc/cli/experimental.rsExperimentalArgs; onlyexperimental_fair_schedremainssrc/cli/run/mod.rs,src/cli/exec/mod.rssrc/executor/config.rsOrchestratorConfig::test()defaults both trueBehavior note
Runner.exclude_allocationsin upload metadata now serializestrueon every simulation run (previously omitted viaskip_serializing_if). This is the intended signal, just always present now.Verification
cargo build,cargo fmt --check,cargo clippy --all-targetsclean.--cycle-estimation,--cycle-estimation=false, and--exclude-allocations=falseall parse; help lists both as normal options.Unsupported systemvalgrind-executor test failures are environment-gated (unsupported valgrind host) and unrelated to this change.