fix: openAI fallback crash in title generation#474
Open
amahuli03 wants to merge 3 commits intoCodeForPhilly:developfrom
Open
fix: openAI fallback crash in title generation#474amahuli03 wants to merge 3 commits intoCodeForPhilly:developfrom
amahuli03 wants to merge 3 commits intoCodeForPhilly:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
summarize_pdf()intitle.pycrashed withAttributeError: 'str' object has no attribute 'choices'when the OpenAI fallback was triggered during file upload.Changes
title.py: Updatedsummarize_pdf()to treat the return value ofopenAIServices.openAI()as a string, since it already extractsmessage.contentinternallytest_title.py: Updated mock return values from mock response objects with.choices[0].message.contentto plain strings, matching the actual return type ofopenAIServices.openAI()Related Issue
Fixes #473
Manual Tests
Uploaded a PDF that uses the OpenAI fallback, confirmed that file was uploaded successfully, title was processed with no errors, and the generated title was correct.
Automated Tests
Updated the unit tests related to OpenAI services in
test_title.pyto reflect the actual data typesReviewers
@sahilds1