Skip to content

Cape Town |26-ITP-May |Enice Mutanda |Sprint 3| Level 500 feature - #93

Open
Enice-Codes wants to merge 15 commits into
CodeYourFuture:mainfrom
Enice-Codes:level-500-feature
Open

Cape Town |26-ITP-May |Enice Mutanda |Sprint 3| Level 500 feature#93
Enice-Codes wants to merge 15 commits into
CodeYourFuture:mainfrom
Enice-Codes:level-500-feature

Conversation

@Enice-Codes

Copy link
Copy Markdown

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | SPRINT NUM | PROJECT NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

completed level 0 to 100
completed level 200 on partners repo
completed level 300 ,400 and 500
deployed to netlify
followed instructions for this project

@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 19, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Sep 2, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Good use of semantic html
  • You have used caching correctly
  • The code is generally well organised
  • It has all the functionality needed

Overall good work, but I can see some areas for improvement, try and give a go at responding to my comments if you want an extra challenge

I notice you have defined and created HTML elements within the js in a lot of places. It's not incorrect, but what do you think the tradeoffs are of doing it this way versus writing it in the HTML file?

You also mix and match different ways of doing this, sometimes defining all the HTML at once, other times adding elements one by one. Could you make it more consistent?

Comment thread script.js

backButton.hidden = false;

controls.innerHTML = `

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you wrote all of this in the Js instead of including it in the html file?

Comment thread script.js
}

function removeHtml(htmlText) {
const temporaryElement = document.createElement("div");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think about why you are doing this. Is it to remove HTML to prevent it from executing when added to the page? One thing to be careful about .innerHTML is this will actually run and execute any HTML passed in even if it's on an element not yet added to the page. There are other techniques that will only parse the HTML instead, can you find one.

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants