London | 26-ITP-May | Damilola Odumosu | Sprint 3 | Level 500 - #98
Open
d-odumosu wants to merge 20 commits into
Open
London | 26-ITP-May | Damilola Odumosu | Sprint 3 | Level 500#98d-odumosu wants to merge 20 commits into
d-odumosu wants to merge 20 commits into
Conversation
merging level-0 to main
Level 100 completed
LONDON | ITP-May-26 | Chinwe Chukwuma | Sprint 2 | Project-TV-Show-Level-200
London | ITP-May-26 | Chinwe Chukwuma | Sprint 2 | Project-Tv-Show
tv show project
LONDON | ITP-May-26 | Chinwe Chukwuma | Sprint 3 | Project TV Show
d-odumosu
added
the
Needs Review
LonMcGregor
reviewed
Sep 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
While testing the app here are some functionality issues I noticed:
- The page gets into an odd state if you select the default item in the dropdown
- Images are sometimes displayed with the wrong aspect ratio
General remarks about the code:
- Good use of HTML templates
- Good use of caching
- Appropriate use of async functions where needed
- The code is generally well organised
Good work so far. ITP is finished now, but you may wish to try and resolve these issues for your own learning.
| const showGenres = showCard.querySelector('.show-genres'); | ||
| const showStatus = showCard.querySelector('.show-status'); | ||
| const showRuntime = showCard.querySelector('.show-runtime'); | ||
| const ratingLabel = document.createElement('strong'); |
Contributor
There was a problem hiding this comment.
Is there a reason you swap between getting a template element and creating some?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelist
Briefly explain your PR.
completed Tv-project up to level 500
netlify: https://cyf-project-tvshow-dodumosu.netlify.app/