Fix fatal error on admin settings page: OC\Server magic getters removed#351
Closed
nd- wants to merge 1 commit into
Closed
Fix fatal error on admin settings page: OC\Server magic getters removed#351nd- wants to merge 1 commit into
nd- wants to merge 1 commit into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Nextcloud core versions where the legacy magic getters have been removed from
OC\Server(confirmed on Nextcloud 34.0.1), loading the admin settings page at/settings/admin/richdocumentscodethrows a fatal error:Admin::getForm()also calls\OC::$server->getAppManager()(line 45), which is affected the same way and would fail right after the first call is fixed.info.xmldeclaresmax-version="35", so the app is expected to work on this core version, but these two direct magic-getter calls were never migrated to the DI container'sget()method like the rest of the app already does elsewhere.Fix
Replace both calls with
\OC::$server->get(SomeInterface::class), which is the supported way to fetch services from the container and remains stable across core versions (confirmed present viaSimpleContainer::get()).Testing
Verified on a Nextcloud 34.0.1 instance: the admin settings page now renders without error after this change.