fix: use safe .get() for 'mode' query param in fetch_customnode_list#2741
Open
HuangYuChuh wants to merge 1 commit into
Open
fix: use safe .get() for 'mode' query param in fetch_customnode_list#2741HuangYuChuh wants to merge 1 commit into
HuangYuChuh wants to merge 1 commit into
Conversation
The `/customnode/getlist` endpoint crashes with `KeyError: 'mode'` when the `mode` query parameter is missing from the request. Extract the mode value once using `.get()` with a default fallback, consistent with how `skip_update` is already handled on the same endpoint. Fixes Comfy-Org#2740 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeyError: 'mode'crash in/customnode/getlistendpoint when themodequery parameter is not providedmodevalue once using.get("mode", "cache")with a default fallback, consistent with howskip_updateis already handled on the same endpointrequest.rel_url.query["mode"]lookups by storing in a local variableFixes #2740
Test plan
/customnode/getlistwithoutmodeparam — should no longer crash/customnode/getlist?mode=local— should work as before/customnode/getlist?mode=cache— should work as before🤖 Generated with Claude Code