Migrate to Uno.Sdk#305
Draft
MartinZikmund wants to merge 25 commits into
Draft
Conversation
MartinZikmund
force-pushed
the
mzikmund/uno-sdk
branch
5 times, most recently
from
b7fd380 to
5290b8f
Compare
MartinZikmund
force-pushed
the
mzikmund/uno-sdk
branch
5 times, most recently
from
25e6b65 to
e673abd
Compare
Comment on lines
272
to
273
| uno-windows: | ||
| runs-on: ubuntu-latest |
Member
There was a problem hiding this comment.
@MartinZikmund this is specifically meant to be a linux runner to just test WASM on another OS.
The CI is failing as the ios workload isn't compatible with ubuntu I guess? (at least that's what the error message seems to indicate).
Do we need the ios workload below?
MartinZikmund
force-pushed
the
mzikmund/uno-sdk
branch
from
041c863 to
4fcc0c4
Compare
^ Conflicts: ^ .github/workflows/build.yml
MartinZikmund
force-pushed
the
mzikmund/uno-sdk
branch
from
4fcc0c4 to
3d1928d
Compare
The job runs on ubuntu-latest but installed ios/maui workloads which aren't supported on Linux, failing at the install step. Uno.Sdk auto-filters the iOS TFM on Linux, so only android + wasm-tools are needed for the desktop/browserwasm heads this job builds. Also renamed the job from the misleading "uno-windows" back to "uno-linux". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The uno-linux job runs on ubuntu-latest and all its build steps use dotnet (slngen, dotnet build). The microsoft/setup-msbuild action is Windows-only and fails on Linux. Remove it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dotnet workload install ran at the repo root before global.json was copied there, so it installed android/wasm-tools for the runner's preinstalled SDK 10 band. The build is pinned to the 9.0.x band via global.json, where no workloads were present, causing NETSDK1147. Run the install from ./tooling so global.json scopes it to the right band. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The new Uno.Sdk head platform entry-point files (Desktop/WebAssembly/ Android/iOS) were missing the standard .NET Foundation license header. Consumers that enforce IDE0073 (file header required) as an error — like CommunityToolkit/Windows — fail to build the Uno head without them. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #304