Skip to content

Fix mount_option_boot_efi_nosuid test scenarios #14225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mab879 merged 1 commit into from
Dec 10, 2025
+10 −2
Merged

Fix mount_option_boot_efi_nosuid test scenarios #14225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...system/permissions/partitions/mount_option_boot_efi_nosuid/tests/vfat_with_nosuid.pass.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
# This test verifies that the rule passes when /boot/efi is mounted with vfat filesystem
# Even with nosuid set, vfat is excluded from the requirement (nosuid has no effect on vfat)

# packages = dosfstools

. $SHARED/partition.sh

clean_up_partition /boot/efi
Expand All @@ -14,7 +16,11 @@ mkfs.vfat $VFAT_PARTITION

# Add to fstab with nosuid option (should still pass because vfat is excluded)
mkdir -p /boot/efi
echo "$VFAT_PARTITION /boot/efi vfat rw,nosuid,relatime 0 0" >> /etc/fstab
echo "$VFAT_PARTITION /boot/efi vfat rw,nosuid,relatime,loop 0 0" >> /etc/fstab

# Mount the partition
mount /boot/efi

# Add verification step to ensure the mount is active and correct
# This helps the script exit with a failure if mount failed unexpectedly
findmnt --target /boot/efi > /dev/null 2>&1
4 changes: 3 additions & 1 deletion ...tem/permissions/partitions/mount_option_boot_efi_nosuid/tests/vfat_without_nosuid.pass.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
# This test verifies that the rule passes when /boot/efi is mounted with vfat filesystem
# The nosuid requirement is not applicable to vfat filesystems

# packages = dosfstools

. $SHARED/partition.sh

clean_up_partition /boot/efi
Expand All @@ -14,7 +16,7 @@ mkfs.vfat $VFAT_PARTITION

# Add to fstab without nosuid option (should pass because vfat is excluded)
mkdir -p /boot/efi
echo "$VFAT_PARTITION /boot/efi vfat rw,relatime 0 0" >> /etc/fstab
echo "$VFAT_PARTITION /boot/efi vfat rw,relatime,loop 0 0" >> /etc/fstab

# Mount the partition
mount /boot/efi
Loading