Edited main.py and test.py#16
Merged
pradeeban merged 4 commits intoControlCore-Project:devfrom Sep 1, 2022
Merged
Conversation
pradeeban
reviewed
Aug 19, 2022
pradeeban
reviewed
Aug 19, 2022
fri/test.py
Outdated
| build("test", "sample1", "xyz") | ||
| debug("sample1") | ||
| destroy("sample1") | ||
| # getFilesList("fri") |
Member
There was a problem hiding this comment.
Why are these two lines commented out?
pradeeban
reviewed
Aug 24, 2022
fri/test.py
Outdated
| files=[ | ||
| ('files[]',('example.py',open(path,'rb'),'application/octet-stream')) | ||
| ] | ||
| # files=[ |
pradeeban
reviewed
Aug 24, 2022
fri/test.py
Outdated
| # file list to be uploaded | ||
| files=[ | ||
| #('files[]',(file_name,open(file_path,'rb'),'application/octet-stream')) | ||
| ('files[]',('controller.py',open('/home/amit/Desktop/test_xyz/controller.py','rb'),'application/octet-stream')), |
Member
There was a problem hiding this comment.
Pls do not hard-code the values such as "/home/amit" as these will not work outside your computer. Use relative paths instead.
Member
There was a problem hiding this comment.
Replace '/home/amit/Desktop/test_xyz/controller.py' with '../demo/controller.py'
pradeeban
reviewed
Sep 1, 2022
pradeeban
requested changes
Sep 1, 2022
Member
pradeeban
left a comment
pradeeban
left a comment
There was a problem hiding this comment.
Please do not remove the "apikey" in the request path of methods.
pradeeban
approved these changes
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.