issue #31#32
Conversation
Currently I am testing some more and will update this PR more when it is completed I will tell you |
| To run the FRI as a server: | ||
| ```` | ||
| $ cd conore | ||
| $ cd conore/fri |
There was a problem hiding this comment.
Yes, this was an issue in the dev branch. It was updated in the main branch. Now I have merged the pull request. So this README should be fixed now.
| resp = jsonify({'message': 'There is an Error'}) | ||
| resp.status_code = 500 | ||
| call(["./build"], cwd=dir_path) | ||
| else: |
There was a problem hiding this comment.
Please keep the PRs to be minimal. If you are addressing a bug, the PR should just address that, instead of making the logs more verbose, like here.
There was a problem hiding this comment.
Actually I put an else block here as if
If block is not executed then resp object will not be defined and will give error , as resp object is only defined inside IF block
There was a problem hiding this comment.
aha, sorry, my bad. You are right.
| dir_path = os.path.abspath(os.path.join(concore_path, graphml_file)) #path for ./build | ||
| if not os.path.exists(dir_path): | ||
| proc = call(["./makestudy", makestudy_dir], cwd=concore_path) | ||
| proc = call(["makestudy", makestudy_dir],shell=True, cwd=concore_path) |
There was a problem hiding this comment.
Thanks. So this fix should be repeated for all the methods (clear, run, ...) I believe?
There was a problem hiding this comment.
yes I will update soon
|
@pradeeban You can review know and if there is anything please let me know |
|
I will also test it on more OS and will tell you if anything breaking |
|
Duplicate of #37. Closing this one in favor of the latest PR. |
2 participants
issue #31