code cleanup#790
Conversation
ensures that operator<< writes to the correct ostream fixes python bindings removes comments of the form // cout << ... fixes and orders includes
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cba2cb15cb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #790 +/- ##
==========================================
- Coverage 36.23% 36.22% -0.01%
==========================================
Files 214 215 +1
Lines 33132 33128 -4
Branches 13171 13173 +2
==========================================
- Hits 12005 12002 -3
+ Misses 19184 19183 -1
Partials 1943 1943 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| */ | ||
| void print() const { | ||
| this->_impl->print(std::cout); | ||
| std::cout << std::string(" Scalar dtype: [") << Type.getname(this->_impl->_dtype) | ||
| << std::string("]") << std::endl; | ||
| void print() const { this->print(std::cout); } | ||
| /// @cond | ||
| void print(std::ostream &os) const { | ||
| this->_impl->print(os); | ||
| os << std::string(" Scalar dtype: [") << Type.getname(this->_impl->_dtype) << std::string("]") | ||
| << std::endl; | ||
| } | ||
| /// @endcond |
There was a problem hiding this comment.
What is the reason to add new methods which consume ostream?
|
You did at least four things in one commit.
To make a PR review by reviewers easier and more quickly, developers are asked to split their great works into multiple commit by logical feature. You can find many sources talking about this principle and try to review PRs. 5.2 Distributed Git - Contributing to a Project
Linux kernel submitting guidelines
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4d2e135bb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08d7678a1a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c7407b253
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
2 participants
ensures that
operator<<writes to the correctostreamfixes python bindings
removes comments of the form
// cout << ...fixes and orders includes