Skip to content

refactor: move getPilotOutput and getPilotLoggingInfo to WebAppHandler#8652

Merged
fstagni merged 1 commit into
DIRACGrid:integrationfrom
fstagni:pilotManagerHadler_removeCEInteractions
Jul 7, 2026
Merged

refactor: move getPilotOutput and getPilotLoggingInfo to WebAppHandler#8652
fstagni merged 1 commit into
DIRACGrid:integrationfrom
fstagni:pilotManagerHadler_removeCEInteractions

Conversation

@fstagni

@fstagni fstagni commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Companion PR for WebApp DIRACGrid/WebAppDIRAC#803

closes #8644

BEGINRELEASENOTES

*WMS
FIX: move getPilotOutput and getPilotLoggingInfo to WebAppHandler

ENDRELEASENOTES

@fstagni fstagni force-pushed the pilotManagerHadler_removeCEInteractions branch 2 times, most recently from 931d4a0 to a2af3d1 Compare July 3, 2026 14:54
@fstagni fstagni force-pushed the pilotManagerHadler_removeCEInteractions branch from a2af3d1 to e452d2f Compare July 3, 2026 14:59
@fstagni fstagni marked this pull request as ready for review July 3, 2026 17:27
@fstagni fstagni requested a review from atsareg as a code owner July 3, 2026 17:27

@aldbr aldbr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using an old client to retrieve a pilot output against a new version of DIRAC would fail because the functions would not exist anymore in the PilotManager.
It is likely ok given that getting a pilot output from the CLI is not a frequent operation, but it should at least be documented somewhere (in the wiki?) as this is a "breaking" change...

To have a transparent change, you would have to redirect PilotManagerHandler.getPilotOutputs to the WebAppHandler I think.

Comment thread tests/Integration/WorkloadManagementSystem/Test_PilotsClient.py
@fstagni

fstagni commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Using an old client to retrieve a pilot output against a new version of DIRAC would fail because the functions would not exist anymore in the PilotManager. It is likely ok given that getting a pilot output from the CLI is not a frequent operation, but it should at least be documented somewhere (in the wiki?) as this is a "breaking" change...

To have a transparent change, you would have to redirect PilotManagerHandler.getPilotOutputs to the WebAppHandler I think.

I know, and considered the fall-back option. I discarded it exactly because it's a manual-only operation, effectively done only through the web (which should be updated at the same time) and by script.

@fstagni fstagni closed this Jul 7, 2026
@fstagni fstagni reopened this Jul 7, 2026
@aldbr

aldbr commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

I know, and considered the fall-back option. I discarded it exactly because it's a manual-only operation, effectively done only through the web (which should be updated at the same time) and by script.

As long as it's fine for the other installations, it looks good to me

@fstagni

fstagni commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

I know, and considered the fall-back option. I discarded it exactly because it's a manual-only operation, effectively done only through the web (which should be updated at the same time) and by script.

As long as it's fine for the other installations, it looks good to me

It does not seem un-reasonable. I will merge now.

@fstagni fstagni merged commit b533c50 into DIRACGrid:integration Jul 7, 2026
45 checks passed
@DIRACGridBot DIRACGridBot added the sweep:ignore Prevent sweeping from being ran for this PR label Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sweep:ignore Prevent sweeping from being ran for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PilotManager refactor

4 participants