Update CMatrix class for SA #284

Aldrin-John-Olaer-Manalansan · 2025-12-13T16:54:18Z

Plugin_SA:

Added member functions to convert between matrix and Euler Angles.
Renamed parameter names of angular rotation-related member functions.
Added CVector version overloads for some member functions.

* Corrected misleading member names: `up -> forward` representing the Y axis `at -> up` representing the Z axis * Adeed member functions to convert between matrix and Euler Angles. * Renamed parameter names of angular rotation related member functions. * Added CVector version overloads for some member functions.

…ross all games It's not right for me to do so but sure

MiranDMC · 2025-12-13T20:48:57Z

plugin_sa/game_sa/CMatrix.cpp

 }

+void CMatrix::SetScale(CVector const &scale) {
+	SetScale(pos.x, pos.y, pos.z);


?

Addessed this incorrect passed parameter in 50621d8

MiranDMC · 2025-12-13T22:13:55Z

What about other game versions?
We are trying to unify util class interfaces across all versions, and this is doing opposite. Check recent updates of CVector class.

* Fixed parameters passed to SetScale overload * renamed Translate related function parameters named "pos" (in conflict with CMatrix member with the same name) into "newPos".

Aldrin-John-Olaer-Manalansan · 2025-12-14T04:46:56Z

What about other game versions? We are trying to unify util class interfaces across all versions, and this is doing opposite. Check recent updates of CVector class.

Which part in the changes opposes the attempt? If you mean Euler Angle conversion wrappers are different/non-existent across games, then this simply suggests that CMatrix isn't suited to be shared. Alternatively, I could preserve the current CMatrix blueprint by adding a new derived class CMatrixInterface containing the new converter methods, exclusive for the game that supports such methods. I would need confirmation from the approver on how to proceed.

MiranDMC · 2025-12-14T12:28:31Z

What about other game versions? We are trying to unify util class interfaces across all versions, and this is doing opposite. Check recent updates of CVector class.

Which part in the changes opposes the attempt? If you mean Euler Angle conversion wrappers are different/non-existent across games, then this simply suggests that CMatrix isn't suited to be shared. Alternatively, I could preserve the current CMatrix blueprint by adding a new derived class CMatrixInterface containing the new converter methods, exclusive for the game that supports such methods. I would need confirmation from the approver on how to proceed.

As said look at recent CVector rework. It abandoned calling in-game code at all in favor of implementing them itself. I had plan to do same with CMatrix but I did not came to it yet (there is still CVector2D to update too).
Then we will have shared utils for all games, making creation of multi target plugins easier.

You can give a try doing same thing with CMatrix.
6ff0e62
Take note there are also Unit Tests for all methods.

Aldrin-John-Olaer-Manalansan · 2025-12-14T14:40:33Z

What about other game versions? We are trying to unify util class interfaces across all versions, and this is doing opposite. Check recent updates of CVector class.

Which part in the changes opposes the attempt? If you mean Euler Angle conversion wrappers are different/non-existent across games, then this simply suggests that CMatrix isn't suited to be shared. Alternatively, I could preserve the current CMatrix blueprint by adding a new derived class CMatrixInterface containing the new converter methods, exclusive for the game that supports such methods. I would need confirmation from the approver on how to proceed.

As said look at recent CVector rework. It abandoned calling in-game code at all in favor of implementing them itself. I had plan to do same with CMatrix but I did not came to it yet (there is still CVector2D to update too). Then we will have shared utils for all games, making creation of multi target plugins easier.

You can give a try doing same thing with CMatrix. 6ff0e62 Take note there are also Unit Tests for all methods.

Not everyone has familiarity across every game. Such mindset puts pressure on collaborators who focus on a specific game, therefore limiting attempts to improve the SDK. Plus, the implementation of CMatrix in GTA SA is a gigantic mess, not sure about the other games, but I would assume the same thing.

This pull request is intended to focus on improving the CMatrix class of Plugin_SA, I'll leave the unification attempt to someone with enough inspiration to implement the entire class by code.

MiranDMC · 2025-12-17T01:30:37Z

plugin_sa/game_sa/CMatrix.h

+	};
+
+	struct t_EulerAngleConversionFlags {
+		unsigned char swapXAndZ: 1 = true; // if set, treats the X axis as Yaw, Z-axis at Pitch


You know C++ has dedicated type for storing true/false values?

Wouldn't really matter either way, a single-bit bitfield resolves the same way as a boolean type. It's a matter of coding discipline at my part.

Just use "coding discipline" already present in the project.

MiranDMC · 2025-12-17T01:34:25Z

Was some AI involved in creation of this? Prefixing types with t_ or e_ is not present in PSDK, gta-reversed or in original sources.

Aldrin-John-Olaer-Manalansan · 2025-12-17T05:05:52Z

Was some AI involved in creation of this? Prefixing types with t_ or e_ is not present in PSDK, gta-reversed or in original sources.

Ofcourse those declarations doesn't exists because those are based on how I perceived the ida pseudo-code. And no, this isn't made by AI either. The choice of naming is just my coding discipline.

* Applied missing const qualifier to signature of `ConvertToEulerAngles` * Added Test Combination Guide for `t_EulerAngleConversionFlags`

* Renamed parameters of Euler Angle Conversion member functions * Removed Confusing Euler Angle Conversion overloads

MiranDMC · 2025-12-24T23:11:03Z

plugin_sa/game_sa/CMatrix.h

+			// The rest of the remaining sequence are yet to discover
+			// ...
+		} sequence;
+		struct {


Is flags struct needed at all? Modern reversed just used enum with values that make sense:
https://github.com/gta-reversed/gta-reversed/blob/master/source/game_sa/Core/Matrix.h#L13
In real use-case person will just want to select one of reasonable options, not spending time configuring each flag one by one in some configuration object.

I was my planing on declaring the conversion flag type into pure enum when the combinations are completely understood. Which is why I decided for the flags struct to stay the way it is as a safer fallback for advanced users to configure onto.

I wasn't aware about reversed source codes containing the euler conversion flags while was specifying the struct type. It's a bad habit of mine of reversing something myself instead of digging onto existing reversed source codes about it. The source material you've tagged here is identical to my findings and seems simpler to use than the current. Yea I think we should adapt the current onto that.

…ix class

Aldrin-John-Olaer-Manalansan added 2 commits December 13, 2025 22:31

Reverted member names into "at" and "up" to match universal naming ac…

5b63247

…ross all games It's not right for me to do so but sure

MiranDMC reviewed Dec 13, 2025

View reviewed changes

Local Variable naming updates for CMatrix

50621d8

* Fixed parameters passed to SetScale overload * renamed Translate related function parameters named "pos" (in conflict with CMatrix member with the same name) into "newPos".

Added default conversion flags

04930a0

MiranDMC reviewed Dec 17, 2025

View reviewed changes

Aldrin-John-Olaer-Manalansan added 4 commits December 22, 2025 23:32

Update CMatrix:

8040034

* Applied missing const qualifier to signature of `ConvertToEulerAngles` * Added Test Combination Guide for `t_EulerAngleConversionFlags`

Update PluginSA CMatrix

76e11b6

Update CMatrix

d017a51

Update PluginSA CMatrix

8a7f80f

* Renamed parameters of Euler Angle Conversion member functions * Removed Confusing Euler Angle Conversion overloads

MiranDMC reviewed Dec 24, 2025

View reviewed changes

Aldrin-John-Olaer-Manalansan added 2 commits December 25, 2025 22:29

Added MultiplyTransposed3x3 function to PluginSA -> common

b4ef64a

Revised euler angle conversion flags declaration at PluginSA -> CMatr…

6af47b1

…ix class

Update CMatrix class for SA #284

Are you sure you want to change the base?

Update CMatrix class for SA #284

Conversation

Aldrin-John-Olaer-Manalansan commented Dec 13, 2025

Uh oh!

MiranDMC Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Aldrin-John-Olaer-Manalansan Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MiranDMC commented Dec 13, 2025

Uh oh!

Aldrin-John-Olaer-Manalansan commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MiranDMC commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aldrin-John-Olaer-Manalansan commented Dec 14, 2025

Uh oh!

MiranDMC Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Aldrin-John-Olaer-Manalansan Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

MiranDMC Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

MiranDMC commented Dec 17, 2025

Uh oh!

Aldrin-John-Olaer-Manalansan commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MiranDMC Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Aldrin-John-Olaer-Manalansan Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Aldrin-John-Olaer-Manalansan Dec 14, 2025 •

edited

Loading

Aldrin-John-Olaer-Manalansan commented Dec 14, 2025 •

edited

Loading

MiranDMC commented Dec 14, 2025 •

edited

Loading

Aldrin-John-Olaer-Manalansan commented Dec 17, 2025 •

edited

Loading

Aldrin-John-Olaer-Manalansan Dec 25, 2025 •

edited

Loading