Feature: Add functionality to mesh handle#2084
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2084 +/- ##
==========================================
+ Coverage 77.56% 77.95% +0.39%
==========================================
Files 113 113
Lines 19025 19087 +62
==========================================
+ Hits 14757 14880 +123
+ Misses 4268 4207 -61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
17 tasks
spenke91
reviewed
Jan 28, 2026
spenke91
requested changes
Jan 29, 2026
Collaborator
spenke91
left a comment
There was a problem hiding this comment.
This is well-written and -documented code, thanks! :-)
I just have a bunch of minor remarks. As usual, feel free to ignore them or argue with me on them -- I think this time I would consider pretty much all of them optional 👍
Co-authored-by: spenke91 <thomas.spenke@dlr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2085
Describe your changes here:
This PR adds multiple functions to the element of a mesh handle, e.g. the diameter and face related functionality as the area of a specific face. We have caches for new functions and new functionality is tested.
Moreover the code is largely restructured to make it shorter and important functions in the element are more visible now.
The testing strategy is sharpened and documented.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).