[ace6tao2] Updated certificates by jwillemsen · Pull Request #2562 · DOCGroup/ACE_TAO

jwillemsen · 2026-08-20T06:36:04Z

Summary by CodeRabbit

Bug Fixes
- SSL examples now detect certificate or private-key loading failures and stop immediately with an error status.
- SSL tests now report configuration failures instead of continuing with invalid setup.
Tests
- Improved error handling makes SSL test failures clearer and more reliable.
Documentation
- Added commands for generating a 2048-bit RSA key and long-lived SHA-256 self-signed certificate.

* ACE/tests/SSL/SSL_Asynch_Stream_Test.cpp: * ACE/tests/SSL/Thread_Pool_Reactor_SSL_Test.cpp:

* ACE/examples/IPC_SAP/SSL_SAP/SSL-client.cpp: * ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp: * ACE/examples/IPC_SAP/SSL_SAP/SSL-server.cpp:

* ACE/tests/SSL/regen_pem.txt: Added. * ACE/tests/SSL/dummy.pem: * ACE/tests/SSL/key.pem:

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* TAO/orbsvcs/DevGuideExamples/Security/ParticipatingApp/cacert.pem: * TAO/orbsvcs/DevGuideExamples/Security/ParticipatingApp/client_cert.pem: * TAO/orbsvcs/DevGuideExamples/Security/ParticipatingApp/client_key.pem: * TAO/orbsvcs/DevGuideExamples/Security/ParticipatingApp/server_cert.pem: * TAO/orbsvcs/DevGuideExamples/Security/ParticipatingApp/server_key.pem: * TAO/orbsvcs/DevGuideExamples/Security/PolicyControllingApp/cacert.pem: * TAO/orbsvcs/DevGuideExamples/Security/PolicyControllingApp/client_cert.pem: * TAO/orbsvcs/DevGuideExamples/Security/PolicyControllingApp/client_key.pem: * TAO/orbsvcs/DevGuideExamples/Security/PolicyControllingApp/server_cert.pem: * TAO/orbsvcs/DevGuideExamples/Security/PolicyControllingApp/server_key.pem: * TAO/orbsvcs/DevGuideExamples/Security/SecurityUnawareApp/cacert.pem: * TAO/orbsvcs/DevGuideExamples/Security/SecurityUnawareApp/client_cert.pem: * TAO/orbsvcs/DevGuideExamples/Security/SecurityUnawareApp/client_key.pem: * TAO/orbsvcs/DevGuideExamples/Security/SecurityUnawareApp/server_cert.pem: * TAO/orbsvcs/DevGuideExamples/Security/SecurityUnawareApp/server_key.pem: * TAO/orbsvcs/tests/Bug_3418_Regression/client_cert.pem: * TAO/orbsvcs/tests/Bug_3418_Regression/client_key.pem: * TAO/orbsvcs/tests/Security/Bug_1107_Regression/cacert.pem: * TAO/orbsvcs/tests/Security/Bug_1107_Regression/client_cert.pem: * TAO/orbsvcs/tests/Security/Bug_1107_Regression/client_key.pem: * TAO/orbsvcs/tests/Security/Bug_1107_Regression/server_cert.pem: * TAO/orbsvcs/tests/Security/Bug_1107_Regression/server_key.pem: * TAO/orbsvcs/tests/Security/Callback/cacert.pem: * TAO/orbsvcs/tests/Security/Callback/client_cert.pem: * TAO/orbsvcs/tests/Security/Callback/client_key.pem: * TAO/orbsvcs/tests/Security/Callback/server_cert.pem: * TAO/orbsvcs/tests/Security/Callback/server_key.pem: * TAO/orbsvcs/tests/Security/Crash_Test/cacert.pem: * TAO/orbsvcs/tests/Security/Crash_Test/client_cert.pem: * TAO/orbsvcs/tests/Security/Crash_Test/client_key.pem: * TAO/orbsvcs/tests/Security/Crash_Test/server_cert.pem: * TAO/orbsvcs/tests/Security/Crash_Test/server_key.pem: * TAO/orbsvcs/tests/Security/MT_IIOP_SSL/server_cert.pem: * TAO/orbsvcs/tests/Security/MT_IIOP_SSL/server_key.pem: * TAO/orbsvcs/tests/Security/MT_SSLIOP/server_cert.pem: * TAO/orbsvcs/tests/Security/MT_SSLIOP/server_key.pem: * TAO/orbsvcs/tests/Security/Null_Cipher/cacert.pem: * TAO/orbsvcs/tests/Security/Null_Cipher/client_cert.pem: * TAO/orbsvcs/tests/Security/Null_Cipher/client_key.pem: * TAO/orbsvcs/tests/Security/Null_Cipher/server_cert.pem: * TAO/orbsvcs/tests/Security/Null_Cipher/server_key.pem: * TAO/orbsvcs/tests/Security/Secure_Invocation/cacert.pem: * TAO/orbsvcs/tests/Security/Secure_Invocation/client_cert.pem: * TAO/orbsvcs/tests/Security/Secure_Invocation/client_key.pem: * TAO/orbsvcs/tests/Security/Secure_Invocation/server_cert.pem: * TAO/orbsvcs/tests/Security/Secure_Invocation/server_key.pem: * TAO/orbsvcs/tests/Security/cert/cacert.pem: * TAO/orbsvcs/tests/Security/cert/client_cert.pem: * TAO/orbsvcs/tests/Security/cert/client_key.pem: * TAO/orbsvcs/tests/Security/cert/server_cert.pem: * TAO/orbsvcs/tests/Security/cert/server_key.pem: * TAO/orbsvcs/tests/Security/mixed_security_test/cacert.pem: * TAO/orbsvcs/tests/Security/mixed_security_test/client_cert.pem: * TAO/orbsvcs/tests/Security/mixed_security_test/client_key.pem: * TAO/orbsvcs/tests/Security/mixed_security_test/server_cert.pem: * TAO/orbsvcs/tests/Security/mixed_security_test/server_key.pem: * TAO/orbsvcs/tests/Security/ssliop_CSD/cacert.pem: * TAO/orbsvcs/tests/Security/ssliop_corbaloc/cacert.pem: * TAO/orbsvcs/tests/Security/ssliop_corbaloc/client_cert.pem: * TAO/orbsvcs/tests/Security/ssliop_corbaloc/client_key.pem: * TAO/orbsvcs/tests/Security/ssliop_corbaloc/server_cert.pem: * TAO/orbsvcs/tests/Security/ssliop_corbaloc/server_key.pem:

coderabbitai · 2026-08-20T06:36:21Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8c563b2c-256c-4afe-88da-e78676ccacf1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9ea59840-3d5d-4466-9e90-e29e4a4f813e

📥 Commits

Reviewing files that changed from the base of the PR and between 03dbf73 and f19d6c2.

⛔ Files ignored due to path filters (64)

ACE/tests/SSL/dummy.pem is excluded by !**/*.pem
ACE/tests/SSL/key.pem is excluded by !**/*.pem
TAO/orbsvcs/DevGuideExamples/Security/ParticipatingApp/cacert.pem is excluded by !**/*.pem
TAO/orbsvcs/DevGuideExamples/Security/ParticipatingApp/client_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/DevGuideExamples/Security/ParticipatingApp/client_key.pem is excluded by !**/*.pem
TAO/orbsvcs/DevGuideExamples/Security/ParticipatingApp/server_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/DevGuideExamples/Security/ParticipatingApp/server_key.pem is excluded by !**/*.pem
TAO/orbsvcs/DevGuideExamples/Security/PolicyControllingApp/cacert.pem is excluded by !**/*.pem
TAO/orbsvcs/DevGuideExamples/Security/PolicyControllingApp/client_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/DevGuideExamples/Security/PolicyControllingApp/client_key.pem is excluded by !**/*.pem
TAO/orbsvcs/DevGuideExamples/Security/PolicyControllingApp/server_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/DevGuideExamples/Security/PolicyControllingApp/server_key.pem is excluded by !**/*.pem
TAO/orbsvcs/DevGuideExamples/Security/SecurityUnawareApp/cacert.pem is excluded by !**/*.pem
TAO/orbsvcs/DevGuideExamples/Security/SecurityUnawareApp/client_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/DevGuideExamples/Security/SecurityUnawareApp/client_key.pem is excluded by !**/*.pem
TAO/orbsvcs/DevGuideExamples/Security/SecurityUnawareApp/server_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/DevGuideExamples/Security/SecurityUnawareApp/server_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Bug_3418_Regression/client_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Bug_3418_Regression/client_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Bug_1107_Regression/cacert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Bug_1107_Regression/client_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Bug_1107_Regression/client_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Bug_1107_Regression/server_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Bug_1107_Regression/server_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Callback/cacert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Callback/client_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Callback/client_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Callback/server_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Callback/server_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Crash_Test/cacert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Crash_Test/client_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Crash_Test/client_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Crash_Test/server_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Crash_Test/server_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/MT_IIOP_SSL/server_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/MT_IIOP_SSL/server_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/MT_SSLIOP/server_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/MT_SSLIOP/server_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Null_Cipher/cacert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Null_Cipher/client_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Null_Cipher/client_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Null_Cipher/server_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Null_Cipher/server_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Secure_Invocation/cacert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Secure_Invocation/client_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Secure_Invocation/client_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Secure_Invocation/server_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/Secure_Invocation/server_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/cert/cacert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/cert/client_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/cert/client_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/cert/server_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/cert/server_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/mixed_security_test/cacert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/mixed_security_test/client_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/mixed_security_test/client_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/mixed_security_test/server_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/mixed_security_test/server_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/ssliop_CSD/cacert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/ssliop_corbaloc/cacert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/ssliop_corbaloc/client_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/ssliop_corbaloc/client_key.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/ssliop_corbaloc/server_cert.pem is excluded by !**/*.pem
TAO/orbsvcs/tests/Security/ssliop_corbaloc/server_key.pem is excluded by !**/*.pem

📒 Files selected for processing (6)

ACE/examples/IPC_SAP/SSL_SAP/SSL-client.cpp
ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp
ACE/examples/IPC_SAP/SSL_SAP/SSL-server.cpp
ACE/tests/SSL/SSL_Asynch_Stream_Test.cpp
ACE/tests/SSL/Thread_Pool_Reactor_SSL_Test.cpp
ACE/tests/SSL/regen_pem.txt

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

SSL examples and tests now check certificate and private-key initialization results. Failed setup stops execution and reports an error. A command file now generates the RSA key and self-signed certificate used by SSL tests.

Changes

SSL initialization error handling

Layer / File(s)	Summary
Example startup checks `ACE/examples/IPC_SAP/SSL_SAP/SSL-client.cpp`, `ACE/examples/IPC_SAP/SSL_SAP/SSL-server.cpp`, `ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp`	The examples check certificate and private-key initialization. Each example returns `-1` when setup fails.
Test setup checks and certificate generation `ACE/tests/SSL/SSL_Asynch_Stream_Test.cpp`, `ACE/tests/SSL/Thread_Pool_Reactor_SSL_Test.cpp`, `ACE/tests/SSL/regen_pem.txt`	The tests report certificate and private-key setup failures and return status 1. The command file generates a 2048-bit RSA key and a SHA-256 self-signed certificate.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to f19d6

This PR updates certificate and key fixtures without any identified current-head issue affecting merge readiness; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

DOCGroup/ACE_TAO#2561: Overlaps these SSL example and test changes, including certificate-generation commands.

Poem

A rabbit checks each key and cert,
No silent failures hide or hurt.
If setup hops onto a wall,
The example stops and tells us all.
Fresh PEM files join the call.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately refers to the certificate-related changes, although the main code change adds error handling for certificate and private-key loading.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

mergify · 2026-08-20T06:36:46Z

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

Queue this pull request

codacy-production · 2026-08-20T06:42:28Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results

Complexity 0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

* ACE/tests/SSL/dummy.pem: * ACE/tests/SSL/key.pem:

jwillemsen and others added 5 commits August 20, 2026 08:25

Check return value of ssl context calls

34dc5bc

* ACE/tests/SSL/SSL_Asynch_Stream_Test.cpp: * ACE/tests/SSL/Thread_Pool_Reactor_SSL_Test.cpp:

Check return calls of the SSL context calls

290bc4f

* ACE/examples/IPC_SAP/SSL_SAP/SSL-client.cpp: * ACE/examples/IPC_SAP/SSL_SAP/SSL-server-fancy.cpp: * ACE/examples/IPC_SAP/SSL_SAP/SSL-server.cpp:

Updated certificates for ACE SSL tests

a74fe62

* ACE/tests/SSL/regen_pem.txt: Added. * ACE/tests/SSL/dummy.pem: * ACE/tests/SSL/key.pem:

Update ACE/tests/SSL/regen_pem.txt

c18aa19

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

New certificates from master

54480bf

* ACE/tests/SSL/dummy.pem: * ACE/tests/SSL/key.pem:

jwillemsen merged commit dc27438 into DOCGroup:ace6tao2 Aug 24, 2026
27 of 28 checks passed

jwillemsen deleted the jwi-sslcertace6tao2 branch August 24, 2026 08:08

Navigation Menu

Uh oh!

[ace6tao2] Updated certificates - #2562

[ace6tao2] Updated certificates#2562
jwillemsen merged 6 commits into
DOCGroup:ace6tao2from
jwillemsen:jwi-sslcertace6tao2

jwillemsen commented Aug 20, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 20, 2026 •

edited

Loading

Review skipped

Uh oh!

mergify Bot commented Aug 20, 2026

Uh oh!

codacy-production Bot commented Aug 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

jwillemsen commented Aug 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Uh oh!

mergify Bot commented Aug 20, 2026

Uh oh!

codacy-production Bot commented Aug 20, 2026

Up to standards ✅

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

1 participant

jwillemsen commented Aug 20, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 20, 2026 •

edited

Loading