Prepare for the CMake plumbing to build the loader with MinGW (2)#18
Prepare for the CMake plumbing to build the loader with MinGW (2)#18illwieckz wants to merge 1 commit into
Conversation
|
Hmm, in fact the CMake plumbing isn't in that PR, but in the general CMake PR. Let's rename it. |
9bf3b1f to
a511b4e
Compare
acdee77 to
a7abb48
Compare
a511b4e to
9bf3b1f
Compare
a7abb48 to
5d12509
Compare
| ; Use of this source code is governed by a BSD-style license that can be | ||
| ; found in the LICENSE file. | ||
|
|
||
| include ksamd64.inc |
There was a problem hiding this comment.
I may mention this in the commit message, but it works because all that is needed is two macros from macamd64.inc, and ksamd64.inc included macamd64.inc so it was overkill to include ksamd64.inc but it worked.
When stubbing it we better make it as short as possible.
On MSVC, the standard macamd64.inc will be used, on MinGW the stub will be used by adding the directory containing it to the list of include directories.
There was a problem hiding this comment.
Also if I remember correctly the standard .inc files use some formatting variants (especially in comment formatting or other useless things like that) that are incompatible with JWasm. The stub is kept as minimal as possible and use a formatting meant to please JWasm. By luck the NaCl .asm file is already compatible with both MASM and JWasm.
Replay of:
Does nothing until: